Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a better time sample in "Dates & Times" setting #1601

Closed
AliabbasMerchant opened this issue Aug 4, 2021 · 4 comments
Closed

Add a better time sample in "Dates & Times" setting #1601

AliabbasMerchant opened this issue Aug 4, 2021 · 4 comments
Assignees
Labels
bug Something isn't working needs-verification Request for community verification
Milestone

Comments

@AliabbasMerchant
Copy link

I (and maybe others also) prefer time in 24H format. So we need to change the date format string. The sample time provided helps in validating whether the resulting date time is in the proper expected format or not.

The current example date and time sample is: July 26th, 2018 4:48am
In this, for checking the final output, since the time is 4:48am, 12h and 24h both have the same representation (04). I would suggest changing it to 4:48pm, so that 12h representation is 04 and 24h is shown as 16.

@AliabbasMerchant AliabbasMerchant added feature New feature or request triage Needs to be looked at labels Aug 4, 2021
@AliabbasMerchant
Copy link
Author

Okay, so the sample datetime in the code is Wed Jul 25 2018 19:18:00 GMT-0400, which changes according to the timezone, hence for example for those of us in India, it is shown as July 26, 4:48am in our timezone.

Any way in which we can circumvent this?
Maybe by having 2 examples?
I believe directly removing the timezone would not work, as it is also essential.

@eamodio eamodio changed the title Minor change: Add a better time sample in "Dates & Times" setting Add a better time sample in "Dates & Times" setting Dec 22, 2021
@eamodio eamodio added bug Something isn't working and removed feature New feature or request triage Needs to be looked at labels Dec 22, 2021
@eamodio eamodio self-assigned this Dec 22, 2021
@eamodio eamodio added this to the Soon™ milestone Dec 22, 2021
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Dec 22, 2021
@eamodio
Copy link
Member

eamodio commented Dec 22, 2021

I'm am now normalizing the default date to be relative to the current timezone, which should help.

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@AliabbasMerchant
Copy link
Author

I installed the insiders edition now. The default date is still "July 26th, 2018 4:48am"

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Mar 1, 2022
@eamodio eamodio modified the milestones: Soon™, Shipped Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for community verification
Projects
None yet
Development

No branches or pull requests

2 participants