Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X.globalState.setKeysForSync is not a function #1609

Closed
slavik-lvovsky opened this issue Aug 16, 2021 · 4 comments
Closed

X.globalState.setKeysForSync is not a function #1609

slavik-lvovsky opened this issue Aug 16, 2021 · 4 comments
Assignees
Labels
bug Something isn't working needs-verification Request for verification
Milestone

Comments

@slavik-lvovsky
Copy link
Contributor

  • GitLens Version: 11.6.0
  • Git Version: Run 2.20.1
  • Theia Version: 1.14.0
  • OS Version: Windows/MAC , All browsers

On the extension activate I get this error:
Activating extension 'GitLens — Git supercharged' failed: X.globalState.setKeysForSync is not a function

Theia version 1.14.0 still does not support vscode API setKeysForSync

We in SAP want to integrate your extension in our webide based on theia 1.14.0
The extension fails.

I will prepare a PR that can fix/eliminate the issue

@slavik-lvovsky
Copy link
Contributor Author

Hi @eamodio, @rebornix and @arrpee ,

We have a client who wants to use this extension in Theia 1.14.0.
Will you be able to review the provided fix for the issue ? #1610

Regards,
Slavik.

@rimasirich
Copy link

Hello @eamodio,
I experience the same issue as well. I would really appreciate if you could have a look on it.
Thank you in advance,
Rima

eamodio pushed a commit to slavik-lvovsky/vscode-gitlens that referenced this issue Nov 3, 2021
@eamodio eamodio self-assigned this Nov 3, 2021
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Nov 3, 2021
@eamodio eamodio added this to the Soon™ milestone Nov 3, 2021
@eamodio eamodio closed this as completed in a03ff94 Nov 3, 2021
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Nov 3, 2021
@eamodio
Copy link
Member

eamodio commented Nov 3, 2021

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Nov 19, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Nov 19, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for verification
Projects
None yet
Development

No branches or pull requests

3 participants