Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlens.remotes: ${repo} has '%2520' instead of '%20' for a space #1669

Closed
NGLocanovic opened this issue Oct 6, 2021 · 8 comments
Closed
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@NGLocanovic
Copy link

Issue Type: Bug

  • GitLens Version: v11.6.0
  • Git Version: git version 2.29.2.windows.2

I configured our companies remote in gitlens settings:

"gitlens.remotes": [
		{
			"domain": "localserver",
			"type": "Custom",
			"name": "localserver",
			"protocol":"https",
			"urls": {
				"repository": "https://localserver/${repo}",
				"branches": "https://localserver/${repo}/branches",
				"branch": "https://localserver/${repo}?version=GB${branch}",
				"commit": "https://localserver/${repo}/commit/${id}",
				"file": "https://localserver/${repo}?path=/${file}",
				"fileInBranch": "https://localserver/${repo}?path=${file}&version=GB${branch}",
				"fileInCommit": "https://localserver/${repo}/commit/${id}?_a=compare&path=/${file}",
				"fileLine": "#L${line}",
				"fileRange": "#L${start}-L${end}"
			}
		}
	]

But when I want to open, lets say a branch on the remote the link looks like this:
https://localserver/DefaultCollection/XXX%2520XXX/_git/DB?version=GBmaster
instead of:
https://localserver/DefaultCollection/XXX%20XXX/_git/DB?version=GBmaster

When I manually remove the '25' from the url, it opens as aspected.

Extension version: 11.6.0
VS Code version: Code 1.60.2 (7f6ab5485bbc008386c4386d08766667e155244e, 2021-09-22T12:00:31.514Z)
OS version: Windows_NT x64 10.0.18363
Restricted Mode: No

@rpodola
Copy link

rpodola commented Oct 7, 2021

Having the same issue.

repo name in git is "/Customer%20Projects/"
but gitlens try to open URL "/Customer%2520Projects/", after removing 25 works really nice

GitLens Insiders: v2021.10.405

@NGLocanovic
Copy link
Author

Is there anything you need, to further track down the problem?

@eamodio eamodio added the bug Something isn't working label Nov 16, 2021
@eamodio eamodio added this to the Soonish™ milestone Nov 16, 2021
@eamodio
Copy link
Member

eamodio commented Nov 16, 2021

I think I have all I need -- looks like a double encoding issue.

@eamodio eamodio modified the milestones: Soonish™, Soon™ Nov 16, 2021
@eamodio eamodio self-assigned this Nov 16, 2021
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Nov 16, 2021
@eamodio
Copy link
Member

eamodio commented Nov 16, 2021

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@rpodola
Copy link

rpodola commented Nov 16, 2021

For me it is working now, thank you :)

insiders edition v2021.11.1604

@eamodio
Copy link
Member

eamodio commented Nov 16, 2021

Thank you!

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for community verification labels Nov 16, 2021
@NGLocanovic
Copy link
Author

Works like a charm! Thanks a lot!

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Nov 19, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Nov 19, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

3 participants