Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant follow symlinks #1776

Closed
HeCodes2Much opened this issue Jan 19, 2022 · 4 comments
Closed

Cant follow symlinks #1776

HeCodes2Much opened this issue Jan 19, 2022 · 4 comments
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@HeCodes2Much
Copy link

HeCodes2Much commented Jan 19, 2022

  • GitLens Version: 11.7.0
  • Git Version: 2.34.1
  • VSCode Version: 1.63.2
  • OS Version: Arch Linux

Steps to Reproduce:

  • file i selected is ~/.config/i3/config the i3 folder is the symlink to the folder below
  • folder it gets the file from in the symlink is /mnt/500GB/.gitlabs/DotFiles/i3/.config/i3/

if i select the file that is not the symlink then it works file but it doesnt seem to like that being a symlink folder

GitLens (Git):

[2022-01-19 11:48:23:980] [/home/repo/.config/i3] git rev-parse --show-toplevel • 29 ms 
[2022-01-19 11:50:44:955] [/mnt/500GB/.gitlabs/DotFiles] git ls-files -- /mnt/500GB/.gitlabs/DotFiles/.config/i3/config • 33 ms 
[2022-01-19 11:50:44:957] [/mnt/500GB/.gitlabs/DotFiles] git ls-files -- /home/repo/.config/i3/config • 19 ms 

GitLens:

[2022-01-19 11:51:52:474] [/mnt/500GB/.gitlabs/DotFiles] git ls-files -- /mnt/500GB/.gitlabs/DotFiles/.config/i3/config • 13 ms 
[2022-01-19 11:51:52:474] [8079] GitService.isTracked returned false • 14 ms — y=GitUri(file:///mnt/500GB/.gitlabs/DotFiles/.config/i3/config repoPath=/mnt/500GB/.gitlabs/DotFiles)
[2022-01-19 11:51:52:475] [/mnt/500GB/.gitlabs/DotFiles] git ls-files -- /home/repo/.config/i3/config • 7 ms 
[2022-01-19 11:51:52:475] [807a] GitService.isTracked returned false • 8 ms — y=GitUri(file:///home/repo/.config/i3/config repoPath=/mnt/500GB/.gitlabs/DotFiles)
@HeCodes2Much HeCodes2Much added potential-bug triage Needs to be looked at labels Jan 19, 2022
@stangelandm1
Copy link

stangelandm1 commented May 9, 2022

More evidence on not being able to handle symlinks or subst drives:

On windows, my whole repo is "subst" to shorten the path for my own convenience (w: -> c:/Users/Username/workspaces/).

  • If I open the project from the subst drive w:/project, GitLens does not work.
  • If I open the non-subst, it works fine.

eamodio added a commit that referenced this issue May 21, 2022
@eamodio eamodio added bug Something isn't working pending-release Resolved but not yet released to the stable edition needs-verification Request for verification and removed potential-bug triage Needs to be looked at labels May 21, 2022
@eamodio eamodio self-assigned this May 21, 2022
@eamodio eamodio added this to the June 2022 milestone May 21, 2022
@eamodio
Copy link
Member

eamodio commented May 21, 2022

Really sorry for the delay on this -- the major refactor GitLens underwent in version 12 to bring virtual repository support and web support made tracking down a performant solution much harder than I had expected/hoped.

Can you please verify this fix in today's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@neelayu
Copy link

neelayu commented May 23, 2022

I am using the insiders version and can confirm this indeed is working fine now. Thanks @eamodio

@eamodio eamodio closed this as completed May 23, 2022
@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels May 23, 2022
@eamodio eamodio modified the milestones: June 2022, 12.0.7 May 25, 2022
eamodio added a commit that referenced this issue May 25, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label May 25, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

4 participants