Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blame annotations not showing anymore after update #1882

Closed
sryze opened this issue Mar 3, 2022 · 14 comments
Closed

Blame annotations not showing anymore after update #1882

sryze opened this issue Mar 3, 2022 · 14 comments
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@sryze
Copy link

sryze commented Mar 3, 2022

GitLens used to show the last commit for each line of code before the update. Now it's not showing anything. The "Current Line" option is turned on.

Additionally, the Toggle Line Blame command is also not working for me.

  • GitLens Version: v12.0.1
  • Git Version: Run git --version 2.28.0.windows.1
  • VSCode Version: Run code --version 1.64.2
  • OS Version: Windows 10
@sryze sryze added potential-bug triage Needs to be looked at labels Mar 3, 2022
@hakimovic
Copy link

Hello, I have the same issue :(

  • GitLens Version: v12.0.1
  • Git Version: Run git --version git version 2.35.1
  • VSCode Version: Run vscodium --version 1.64.2
  • OS Version: Manjaro Linux

@eamodio
Copy link
Member

eamodio commented Mar 7, 2022

Can you please enable debug logging by running from GitLens: Enable Debug Logging from the Command Palette (F1 or ctrl/cmd+shift+p). This will enable logging to the GitLens and GitLens (Git) channel in the Output pane.

Once enabled, please reproduce the issue, and attach the log from the both GitLens and GitLens (Git) channels.

Thank you!

@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Mar 7, 2022
@sryze
Copy link
Author

sryze commented Mar 9, 2022

I think it's related to symlinks. When I open my project through a path that contains a symlink (created via mklink /D) GitLens doesn't work. But if I open the same folder using the actual path, it works fine.

To reproduce create a link like this via Command Prompt:

mklink /D C:\Users\your_user\Projects D:\Projects

gitlens_log.txt
gitlens_git_log.txt

@github-actions github-actions bot added the inactive Issue has not had recent required feedback label Mar 17, 2022
@gitkraken gitkraken deleted a comment from github-actions bot Mar 17, 2022
@eamodio eamodio added triage Needs to be looked at and removed needs-more-info Needs further information, steps, details, etc. inactive Issue has not had recent required feedback labels Mar 17, 2022
@alpsayin
Copy link

Same here.

Instead of sending canned responses on marketplace reviews about asking to open issues on github*, how about getting your house in order first?
And also, perhaps test things bit more before introducing breaking changes also while forcing subscription on a loyal user base who's never coming back after what just happened here.
Ciao

*only here to annoy your developers -by contributing absolutely nothing with this reply- because your management team obviously pushed for a sped up release, and because your management -and probably an intern seo- thinks you can damage control by redirecting your user base to github issues. you mad yet? good, get mad at your management, show them this ("this" being utter incompetence on gitkraken's takeover)

p.s. maybe i'm wrong about most of this, but i'm definitely not wrong about the clear demonstration of utter incompetence

@joseleon-axosoft joseleon-axosoft self-assigned this Mar 22, 2022
@mrAntiUser
Copy link

I confirm the problem - #1926

make folder "Point"
make folder "g1"
clone repo to g1
make NTFS junction point on Point dir from g1
now Point see on g1
Open any file from Point in VSCode
see crash on show file history

@rezonant
Copy link

rezonant commented Apr 7, 2022

For users facing this issue, if you happen to have configured git-blame-ignore-revs, this might be relevant: #1143

@runfeng1998
Copy link

runfeng1998 commented Apr 7, 2022 via email

@eamodio eamodio assigned eamodio and unassigned joseleon-axosoft Apr 13, 2022
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Apr 13, 2022
@eamodio eamodio added this to the Soon™ milestone Apr 13, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Apr 13, 2022
@eamodio
Copy link
Member

eamodio commented Apr 13, 2022

Can you please verify this fix in the GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@lingwei5
Copy link

lingwei5 commented May 5, 2022

still have such issue with gitlen 2022.4.2705

I think it's related to symlinks. When I open my project through a path that contains a symlink (created via mklink /D) GitLens doesn't work. But if I open the same folder using the actual path, it works fine.

To reproduce create a link like this via Command Prompt:

mklink /D C:\Users\your_user\Projects D:\Projects

gitlens_log.txt gitlens_git_log.txt

@joseleon-axosoft
Copy link

Going to check.

joseleon-axosoft added a commit to joseleon-axosoft/vscode-gitlens that referenced this issue May 12, 2022
…ymbolic link, quick and dirty prototype, not to be merged as is
@eamodio eamodio reopened this May 16, 2022
@eamodio eamodio modified the milestones: Soon™, June 2022 May 16, 2022
@eamodio eamodio removed pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels May 16, 2022
@swrobel
Copy link

swrobel commented May 20, 2022

I just installed the Insider version and disabled the regular extension version, and restarted VSCode, and I notice no changes. I can see blame on the lines when viewing the original file (config/Gemfile.lock), and no blame when viewing the symlinked version (Gemfile.lock). Here is a log viewing the symlinked version first:

[2022-05-20 00:21:57.335] [   70] GitUri.fromUri — ie=Uri(file:///Users/swrobel/Code/lw-web/Gemfile)
[2022-05-20 00:21:57.335] [   71] GitProviderService.getOrOpenRepository — o=Uri(file:///Users/swrobel/Code/lw-web/Gemfile)
[2022-05-20 00:21:57.335] [   72] GitProviderService.getRepository — o=Uri(file:///Users/swrobel/Code/lw-web/Gemfile)
[2022-05-20 00:21:57.335] [   72] GitProviderService.getRepository returned /Users/swrobel/Code/lw-web • 0 ms
[2022-05-20 00:21:57.335] [   73] LineAnnotationController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/Gemfile, selections=undefined, pending=true, reason=selection
[2022-05-20 00:21:57.335] [   74] LineAnnotationController.clear completed • 0 ms
[2022-05-20 00:21:57.335] [   73] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:57.335] [   75] LineHoverController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/Gemfile, selections=undefined, pending=true, reason=selection
[2022-05-20 00:21:57.335] [   75] LineHoverController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:57.335] [   76] StatusBarController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/Gemfile, selections=undefined, pending=true, reason=selection
[2022-05-20 00:21:57.335] [   76] StatusBarController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:57.335] [   71] GitProviderService.getOrOpenRepository returned /Users/swrobel/Code/lw-web • 0 ms
[2022-05-20 00:21:57.336] [   70] GitUri.fromUri returned GitUri(file:///Users/swrobel/Code/lw-web/Gemfile repoPath=/Users/swrobel/Code/lw-web) • 1 ms
[2022-05-20 00:21:57.336] [   77] GitProviderService.getRepository — o=GitUri(file:///Users/swrobel/Code/lw-web/Gemfile repoPath=/Users/swrobel/Code/lw-web)
[2022-05-20 00:21:57.336] [   77] GitProviderService.getRepository returned /Users/swrobel/Code/lw-web • 0 ms
[2022-05-20 00:21:57.336] [   78] LocalGitProvider.isTrackedPrivate — e=GitUri(file:///Users/swrobel/Code/lw-web/Gemfile repoPath=/Users/swrobel/Code/lw-web)
[2022-05-20 00:21:57.336] [   79] GitProviderService.getRepository — o=GitUri(file:///Users/swrobel/Code/lw-web/Gemfile repoPath=/Users/swrobel/Code/lw-web)
[2022-05-20 00:21:57.336] [   79] GitProviderService.getRepository returned /Users/swrobel/Code/lw-web • 0 ms
[2022-05-20 00:21:57.336] [   7a] LocalGitProvider.isTrackedCore — e=/Users/swrobel/Code/lw-web/Gemfile, t=Gemfile, i=/Users/swrobel/Code/lw-web, s=undefined, f=<error>
[2022-05-20 00:21:57.340] [GIT  ] [/Users/swrobel/Code/lw-web] git ls-files -- Gemfile • 4 ms
[2022-05-20 00:21:57.340] [   7a] LocalGitProvider.isTrackedCore completed • 4 ms
[2022-05-20 00:21:57.340] [   78] LocalGitProvider.isTrackedPrivate returned true • 4 ms
[2022-05-20 00:21:57.586] [   7c] GitProviderService.getBlameForLine — o=GitUri(file:///Users/swrobel/Code/lw-web/Gemfile repoPath=/Users/swrobel/Code/lw-web), e=29, t={"uri":{"$mid":1,"fsPath":"/Users/swrobel/Code/lw-web/Gemfile","external":"file:///Users/swrobel/Code/lw-web/Gemfile","path":"/Users/swrobel/Code/lw-web/Gemfile","scheme":"file"},"fileName":"/Users/swrobel/Code/lw-web/Gemfile","isUntitled":false,"languageId":"gemfile","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":119}
[2022-05-20 00:21:57.586] [   7d] LocalGitProvider.getBlameForLine — e=GitUri(file:///Users/swrobel/Code/lw-web/Gemfile repoPath=/Users/swrobel/Code/lw-web), t=29, i={"uri":{"$mid":1,"fsPath":"/Users/swrobel/Code/lw-web/Gemfile","external":"file:///Users/swrobel/Code/lw-web/Gemfile","path":"/Users/swrobel/Code/lw-web/Gemfile","scheme":"file"},"fileName":"/Users/swrobel/Code/lw-web/Gemfile","isUntitled":false,"languageId":"gemfile","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":119}, s=undefined
[2022-05-20 00:21:57.586] [   7e] LocalGitProvider.getBlame — e=GitUri(file:///Users/swrobel/Code/lw-web/Gemfile repoPath=/Users/swrobel/Code/lw-web)
[2022-05-20 00:21:57.586] [   7e] LocalGitProvider.getBlame Cache miss: 'blame'
[2022-05-20 00:21:57.586] [   7f] LocalGitProvider.isTrackedPrivate — e=GitUri(file:///Users/swrobel/Code/lw-web/Gemfile repoPath=/Users/swrobel/Code/lw-web)
[2022-05-20 00:21:57.586] [   80] GitProviderService.getRepository — o=GitUri(file:///Users/swrobel/Code/lw-web/Gemfile repoPath=/Users/swrobel/Code/lw-web)
[2022-05-20 00:21:57.586] [   80] GitProviderService.getRepository returned /Users/swrobel/Code/lw-web • 0 ms
[2022-05-20 00:21:57.586] [   7e] LocalGitProvider.getBlame Cache add: 'blame'
[2022-05-20 00:21:57.586] [   7f] LocalGitProvider.isTrackedPrivate returned true • 0 ms
[2022-05-20 00:21:57.600] [GIT  ] [/Users/swrobel/Code/lw-web] git blame --root --incremental -- Gemfile • 13 ms
[2022-05-20 00:21:57.600] [   81] LocalGitProvider.getCurrentUser — e=/Users/swrobel/Code/lw-web
[2022-05-20 00:21:57.600] [   81] LocalGitProvider.getCurrentUser completed • 0 ms
[2022-05-20 00:21:57.600] [   82] GitBlameParser.parse completed • 0 ms
[2022-05-20 00:21:57.600] [   7e] LocalGitProvider.getBlame completed • 13 ms
[2022-05-20 00:21:57.600] [   7d] LocalGitProvider.getBlameForLine completed • 13 ms
[2022-05-20 00:21:57.600] [   7c] GitProviderService.getBlameForLine completed • 13 ms
[2022-05-20 00:21:57.600] [   7b] GitLineTracker.updateState returned false • blame failed • 13 ms — e=29, t=file:///Users/swrobel/Code/lw-web/Gemfile
[2022-05-20 00:21:57.600] [   83] LineAnnotationController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/Gemfile, selections=undefined, pending=false, reason=selection
[2022-05-20 00:21:57.600] [   84] LineAnnotationController.clear completed • 0 ms
[2022-05-20 00:21:57.600] [   83] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:57.600] [   85] LineHoverController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/Gemfile, selections=undefined, pending=false, reason=selection
[2022-05-20 00:21:57.600] [   85] LineHoverController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:57.600] [   86] StatusBarController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/Gemfile, selections=undefined, pending=false, reason=selection
[2022-05-20 00:21:57.600] [   86] StatusBarController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:59.621] [   87] SubscriptionService.ensureSession — o=false
[2022-05-20 00:21:59.621] [   87] SubscriptionService.ensureSession completed • 0 ms
[2022-05-20 00:21:59.695] [   88] LineAnnotationController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/config/Gemfile, selections=undefined, pending=true, reason=selection
[2022-05-20 00:21:59.695] [   89] LineAnnotationController.clear completed • 0 ms
[2022-05-20 00:21:59.695] [   88] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:59.695] [   8a] LineHoverController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/config/Gemfile, selections=undefined, pending=true, reason=selection
[2022-05-20 00:21:59.695] [   8a] LineHoverController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:59.695] [   8b] StatusBarController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/config/Gemfile, selections=undefined, pending=true, reason=selection
[2022-05-20 00:21:59.695] [   8b] StatusBarController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:59.945] [   8d] GitProviderService.getBlameForLine — o=GitUri(file:///Users/swrobel/Code/lw-web/config/Gemfile repoPath=/Users/swrobel/Code/lw-web), e=15, t={"uri":{"$mid":1,"fsPath":"/Users/swrobel/Code/lw-web/config/Gemfile","external":"file:///Users/swrobel/Code/lw-web/config/Gemfile","path":"/Users/swrobel/Code/lw-web/config/Gemfile","scheme":"file"},"fileName":"/Users/swrobel/Code/lw-web/config/Gemfile","isUntitled":false,"languageId":"gemfile","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":119}
[2022-05-20 00:21:59.946] [   8e] LocalGitProvider.getBlameForLine — e=GitUri(file:///Users/swrobel/Code/lw-web/config/Gemfile repoPath=/Users/swrobel/Code/lw-web), t=15, i={"uri":{"$mid":1,"fsPath":"/Users/swrobel/Code/lw-web/config/Gemfile","external":"file:///Users/swrobel/Code/lw-web/config/Gemfile","path":"/Users/swrobel/Code/lw-web/config/Gemfile","scheme":"file"},"fileName":"/Users/swrobel/Code/lw-web/config/Gemfile","isUntitled":false,"languageId":"gemfile","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":119}, s=undefined
[2022-05-20 00:21:59.946] [   8f] LocalGitProvider.getBlame — e=GitUri(file:///Users/swrobel/Code/lw-web/config/Gemfile repoPath=/Users/swrobel/Code/lw-web)
[2022-05-20 00:21:59.946] [   8f] LocalGitProvider.getBlame Cache hit: 'blame'
[2022-05-20 00:21:59.946] [   8f] LocalGitProvider.getBlame completed • 0 ms
[2022-05-20 00:21:59.946] [   8e] LocalGitProvider.getBlameForLine completed • 0 ms
[2022-05-20 00:21:59.946] [   8d] GitProviderService.getBlameForLine completed • 0 ms
[2022-05-20 00:21:59.946] [   8c] GitLineTracker.updateState returned true • 0 ms — e=15, t=file:///Users/swrobel/Code/lw-web/config/Gemfile
[2022-05-20 00:21:59.946] [   90] LineAnnotationController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/config/Gemfile, selections=[15-15], pending=false, reason=selection
[2022-05-20 00:21:59.946] [   91] LineAnnotationController.refresh
[2022-05-20 00:21:59.946] [   92] LineAnnotationController.clear completed • 0 ms
[2022-05-20 00:21:59.946] [   90] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:59.946] [   93] LineHoverController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/config/Gemfile, selections=[15-15], pending=false, reason=selection
[2022-05-20 00:21:59.946] [   93] LineHoverController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:59.946] [   94] StatusBarController.onActiveLinesChanged — e=editor=file:///Users/swrobel/Code/lw-web/config/Gemfile, selections=[15-15], pending=false, reason=selection
[2022-05-20 00:21:59.946] [   95] StatusBarController.updateBlame
[2022-05-20 00:21:59.946] [   96] GitProviderService.getRichRemoteProvider — o=/Users/swrobel/Code/lw-web
[2022-05-20 00:21:59.946] [   94] StatusBarController.onActiveLinesChanged completed • 0 ms
[2022-05-20 00:21:59.946] [   96] GitProviderService.getRichRemoteProvider completed • 0 ms
[2022-05-20 00:21:59.946] [   97] GitProviderService.getRichRemoteProvider — o=/Users/swrobel/Code/lw-web
[2022-05-20 00:21:59.946] [   97] GitProviderService.getRichRemoteProvider completed • 0 ms
[2022-05-20 00:21:59.946] [   95] StatusBarController.updateBlame completed • 0 ms
[2022-05-20 00:21:59.947] [   91] LineAnnotationController.refresh completed • selection(s)=[15-15] • 0 ms
[2022-05-20 00:22:00.447] [   98] GitProviderService.getRemotesWithProviders — o=/Users/swrobel/Code/lw-web, e={"sort":true}
[2022-05-20 00:22:00.447] [   99] GitProviderService.getRepository — o=/Users/swrobel/Code/lw-web
[2022-05-20 00:22:00.447] [   99] GitProviderService.getRepository returned /Users/swrobel/Code/lw-web • 0 ms
[2022-05-20 00:22:00.447] [   98] GitProviderService.getRemotesWithProviders completed • 0 ms
[2022-05-20 00:22:00.447] [  154] Hovers.getAutoLinkedIssuesOrPullRequests — message=<message>
[2022-05-20 00:22:00.447] [   9b] GitProviderService.getRichRemoteProvider — o=origin
[2022-05-20 00:22:00.447] [  156] Hovers.getPullRequestForCommit — ref=36b4c2fc05fd3b4d1c886eb46e2dc823b397a654
[2022-05-20 00:22:00.447] [   9d] GitProviderService.getRichRemoteProvider — o=origin, e={"includeDisconnected":true}
[2022-05-20 00:22:00.447] [   9e] VslsController.maybeGetPresence — swrobel@users.noreply.github.com
[2022-05-20 00:22:00.447] [   9f] VslsController.getContactPresence — e=swrobel@users.noreply.github.com
[2022-05-20 00:22:00.447] [   a0] VslsController.getContact — e=swrobel@users.noreply.github.com
[2022-05-20 00:22:00.447] [   9b] GitProviderService.getRichRemoteProvider completed • 0 ms
[2022-05-20 00:22:00.447] [   9d] GitProviderService.getRichRemoteProvider completed • 0 ms
[2022-05-20 00:22:00.448] [  154] Hovers.getAutoLinkedIssuesOrPullRequests completed • 0 ms
[2022-05-20 00:22:00.448] [  156] Hovers.getPullRequestForCommit completed • 0 ms
[2022-05-20 00:22:00.448] [   a0] VslsController.getContact completed • 0 ms
[2022-05-20 00:22:00.448] [   9f] VslsController.getContactPresence completed • 0 ms
[2022-05-20 00:22:00.448] [   9e] VslsController.maybeGetPresence completed • 0 ms
[2022-05-20 00:22:00.448] [   a1] Autolinks.linkify — <text>, t=true, i=1, s=undefined, f=0
[2022-05-20 00:22:00.448] [   a1] Autolinks.linkify completed • 0 ms
[2022-05-20 00:22:00.448] [   a2] GitProviderService.getRevisionUri — o=0ddcd769046303a3b05312e61322d463b402060a, e=config/Gemfile, t=/Users/swrobel/Code/lw-web
[2022-05-20 00:22:00.448] [   a2] GitProviderService.getRevisionUri completed • 0 ms
[2022-05-20 00:22:00.448] [   a3] GitProviderService.getRevisionUri — o=GitUri(file:///Users/swrobel/Code/lw-web/config/Gemfile repoPath=/Users/swrobel/Code/lw-web sha=36b4c2fc05fd3b4d1c886eb46e2dc823b397a654)
[2022-05-20 00:22:00.448] [   a3] GitProviderService.getRevisionUri completed • 0 ms
[2022-05-20 00:22:01.251] [   a4] LineHoverController.provideDetailsHover — e=Uri(file:///Users/swrobel/Code/lw-web/config/Gemfile), t=24:55
[2022-05-20 00:22:01.251] [   a5] LineHoverController.provideChangesHover — e=Uri(file:///Users/swrobel/Code/lw-web/config/Gemfile), t=24:55
[2022-05-20 00:22:01.251] [   a4] LineHoverController.provideDetailsHover completed • 0 ms
[2022-05-20 00:22:01.251] [   a5] LineHoverController.provideChangesHover completed • 0 ms

macOS 12.4 (m1)
vscode 1.67.2
GitLens v2022.5.1705

eamodio added a commit that referenced this issue May 21, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels May 21, 2022
@eamodio
Copy link
Member

eamodio commented May 21, 2022

Really sorry for the delay on this -- the major refactor GitLens underwent in version 12 to bring virtual repository support and web support made tracking down a performant solution much harder than I had expected/hoped.

Can you please verify this fix in today's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@eamodio eamodio closed this as completed May 21, 2022
@joseleon-axosoft
Copy link

I have verified blame annotations work again for folders containing symlinks.

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels May 23, 2022
@eamodio eamodio modified the milestones: June 2022, 12.0.7 May 25, 2022
eamodio added a commit that referenced this issue May 25, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label May 25, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

10 participants