Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated GitHub errors when offline #1897

Closed
srl295 opened this issue Mar 9, 2022 · 3 comments
Closed

Repeated GitHub errors when offline #1897

srl295 opened this issue Mar 9, 2022 · 3 comments
Assignees
Milestone

Comments

@srl295
Copy link

srl295 commented Mar 9, 2022

#152 asked: "How far can I go without an internet connect?" Answer is not very far. GitLens is great, BUT this is a bug.

  • GitLens Version: v12.0.2
  • Git Version: git version 2.32.0
  • VSCode Version:
    1.66.0-insider
    e80a0ca648fe9bef07070e4f7fb04e67f2243252
    x64

  • OS Version:
    macos monterey 12.2.1 (21D62)

Steps to Reproduce:

  1. Fire up VSCode
  2. Click on source lines
  3. Get lots of annoying popups

Instead, just work with data you have, maybe show a broken symbol in the status bar or on popups.

I have to include this screenshot, with the irony of an "unobtrusive" feature…

BUGS- GitLens

@srl295 srl295 added potential-bug triage Needs to be looked at labels Mar 9, 2022
@srl295
Copy link
Author

srl295 commented Mar 9, 2022

Related to #1893 (where GitHub is completely blocked) and #1869 (too many requests)

@eamodio eamodio changed the title broken offline Repeated GitHub errors when offline Mar 10, 2022
@eamodio eamodio self-assigned this Mar 10, 2022
@eamodio eamodio added bug and removed potential-bug triage Needs to be looked at labels Mar 10, 2022
@eamodio eamodio added this to the Soon™ milestone Mar 10, 2022
@eamodio
Copy link
Member

eamodio commented Mar 10, 2022

Sorry for the trouble on this one, I got overzealous on displaying errors 😢. These should be completely silenced now.

@eamodio eamodio modified the milestones: Soon™, Shipped Mar 10, 2022
eamodio added a commit that referenced this issue Mar 25, 2022
Hides unexpected GitHub errors for now
Refs #1893
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants