Should still "detect" repos directly in the workspace folder(s) even if git.autoRepositoryDetection is false

[mattklein123]

After upgrading to 12.0.4, the extension no longer seems to load. None of the windows are present in the source control tab, and if I try to switch back to the GitLens view (vs. source integration), nothing shows up there either. It's like the extension fails to load. If I revert back to 12.0.3 everything works OK. Please let me know what other info I can provide to help debug.

• GitLens Version: 12.0.4
• Git Version: git version 2.32.0

Version: 1.65.2
Commit: c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1
Date: 2022-03-10T15:36:26.048Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.13.0-35-generic

[2022-03-15 19:25:27.253] [    1] GitLens v12.0.4 activating in Visual Studio Code(1.65.2) on the desktop
[2022-03-15 19:25:27.254] [    2] SubscriptionService.changeSubscription — d={"plan":{"actual":{"id":"free","name":"GitLens","startedOn":"2022-03-15T19:24:14.396Z"},"effective":{"id":"free","name":"GitLens","startedOn":"2022-03-15T19:24:14.396Z"}},"state":0}, e=true
[2022-03-15 19:25:27.254] [    2] SubscriptionService.changeSubscription completed • 0 ms
[2022-03-15 19:25:27.259] [    3] Container.registerGitProviders
[2022-03-15 19:25:27.261] [    4] GitProviderService.accessCore — j=undefined, z=undefined
[2022-03-15 19:25:27.261] [    5] SubscriptionService.ensureSession — d=false
[2022-03-15 19:25:27.261] [    6] SubscriptionService.getOrCreateSession — d=false
[2022-03-15 19:25:27.267] [    7] GitProviderService.register completed • 0 ms — j=git
[2022-03-15 19:25:27.267] [    8] GitProviderService.register completed • 0 ms — j=vsls
[2022-03-15 19:25:27.267] [    9] GitProviderService.register completed • 0 ms — j=github
[2022-03-15 19:25:27.267] [    a] GitProviderService.registrationComplete completed • 0 ms
[2022-03-15 19:25:27.272] [    3] Container.registerGitProviders completed • 13 ms
[2022-03-15 19:25:27.273] [    b] GitLineTracker.unsubscribe
[2022-03-15 19:25:27.273] [    b] GitLineTracker.unsubscribe completed • 0 ms
[2022-03-15 19:25:27.273] [    c] LineAnnotationController.refresh
[2022-03-15 19:25:27.273] [    d] GitLineTracker.unsubscribe
[2022-03-15 19:25:27.273] [    d] GitLineTracker.unsubscribe completed • 0 ms
[2022-03-15 19:25:27.273] [    e] GitLineTracker.unsubscribe
[2022-03-15 19:25:27.273] [    e] GitLineTracker.unsubscribe completed • 0 ms
[2022-03-15 19:25:27.277] [    1] GitLens v12.0.4 activated, syncedVersion=12.0.4, localVersion=12.0.4, previousVersion=12.0.4, welcome=false • 23 ms
[2022-03-15 19:25:27.277] [    c] LineAnnotationController.refresh completed • 3 ms
[2022-03-15 19:25:27.359] [    f] SubscriptionAuthenticationProvider.getSessions — e=["gitlens"]
[2022-03-15 19:25:27.360] [    f] SubscriptionAuthenticationProvider.getSessions completed • Found 0 sessions • 0 ms
[2022-03-15 19:25:27.374] [   10] SubscriptionService.logout
[2022-03-15 19:25:27.374] [   11] SubscriptionAuthenticationProvider.abort
[2022-03-15 19:25:27.374] [   12] ServerConnection.abort
[2022-03-15 19:25:27.374] [   12] ServerConnection.abort completed • 0 ms
[2022-03-15 19:25:27.374] [   11] SubscriptionAuthenticationProvider.abort completed • 0 ms
[2022-03-15 19:25:27.374] [   13] SubscriptionService.changeSubscription — d={"plan":{"actual":{"id":"free","name":"GitLens","startedOn":"2022-03-15T19:25:27.374Z"},"effective":{"id":"free","name":"GitLens","startedOn":"2022-03-15T19:25:27.374Z"}},"state":0}
[2022-03-15 19:25:27.374] [   14] GitProviderService.onSubscriptionChanged — j={"current":{"plan":{"actual":{"id":"free","name":"GitLens","startedOn":"2022-03-15T19:25:27.374Z"},"effective":{"id":"free","name":"GitLens","startedOn":"2022-03-15T19:25:27.374Z"}},"state":0},"previous":{"plan":{"actual":{"id":"free","name":"GitLens","startedOn":"2022-03-15T19:24:14.396Z"},"effective":{"id":"free","name":"GitLens","startedOn":"2022-03-15T19:24:14.396Z"}},"state":0},"etag":1647372327374}
[2022-03-15 19:25:27.374] [   14] GitProviderService.onSubscriptionChanged completed • 0 ms
[2022-03-15 19:25:27.374] [   13] SubscriptionService.changeSubscription completed • 0 ms
[2022-03-15 19:25:27.375] [   15] GitProviderService.accessCore — j=undefined, z=undefined
[2022-03-15 19:25:27.375] [   10] SubscriptionService.logout completed • 0 ms
[2022-03-15 19:25:27.375] [    6] SubscriptionService.getOrCreateSession completed • 113 ms
[2022-03-15 19:25:27.375] [   15] GitProviderService.accessCore completed • 0 ms
[2022-03-15 19:25:27.375] [    5] SubscriptionService.ensureSession completed • 114 ms
[2022-03-15 19:25:27.375] [    4] GitProviderService.accessCore completed • 114 ms
[2022-03-15 19:25:37.255] [   16] SubscriptionService.ensureSession — d=false
[2022-03-15 19:25:37.255] [   16] SubscriptionService.ensureSession completed • 0 ms
[2022-03-15 19:26:27.008] [   17] GitProviderService.onWindowStateChanged — j=focused=false
[2022-03-15 19:26:27.008] [   17] GitProviderService.onWindowStateChanged completed • 0 ms
[2022-03-15 19:26:27.278] ShowMessage(warn, 'GitLens debug logging is currently enabled. Unless you are reporting an issue, it is recommended to be disabled. Would you like to disable it?', suppressDebugLoggingWarning, {"title":"Don't Show Again"})

[mattklein123]

I just looked through the change log and at some point I had set "auto repository detection" to false. This used to work OK but seems to not work anymore after 12.0.4. Is this expected? I switched it to subFolders and it seems to load now.

[kensoldink]

I was running into this exact issue, and @mattklein123 suggestion to set "git.autoRepositoryDetection": "subFolders" fixes things!

[eamodio]

Yes, prior to 12.0.4 GitLens was not honoring the git.autoRepositoryDetection, which it now does.

Curiously why would you all have disabled it?

[kensoldink]

I had this turned off primarily to ignore VaryingVagrantVagrant's repo from pulling in and showing up in Source Control while working on a site within VVV. It's not a big deal, and I believe there's other ways around this (Git exclude?)

[mattklein123]

Yes same for me. I work in large projects that pull in transitive dependencies that sometimes are git repos on disk, and I don't want them to show up in my source control view, so I disabled this feature.

The thing that I don't quite understand though is that even with set to "false", the repo was still present in the "stock" source code view? Shouldn't GL also pull it up in that case?

[mattklein123]

I'm actually not sure that subFolders will work for me, since I think it may still pull in repos via sub-folder symlinks. If set to "false" is there some way to manually load repos into the GL UI?

[eamodio]

OK, it looks like my "honoring" of the setting was overzealous. I'll put in a fix that will still "discover" the repository if it's directly in the workspace folder (which I assume is what VS Code is doing). I also have to check, because GitLens is supposed to get notified of the VS Code repos and add them too.

I'm make sure this is in the GitLens Insiders edition tonight. Sorry for the trouble. And thank you for the additional details.

[mattklein123]

Awesome thank you for the quick response!

[eamodio]

Closed by 89010fa

[eamodio]

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.