Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request autolink doesn't work for Bitbucket Server 7 #1932

Closed
smartinio opened this issue Mar 29, 2022 · 4 comments · Fixed by #1933
Closed

Pull request autolink doesn't work for Bitbucket Server 7 #1932

smartinio opened this issue Mar 29, 2022 · 4 comments · Fixed by #1933
Assignees
@eamodio
Labels
bug Something isn't working verified ✔ Verified
Milestone
Shipped

Comments

@smartinio
Copy link

The default merge commit message casing of "pull request" was changed to "Pull request" in Bitbucket Server 7. Therefore, the autolink no longer works.

  • GitLens Version: 12.0.5
  • Git Version: 2.32.0
  • VSCode Version: 1.65.2
  • OS Version: macOS Monterey 12.3

Steps to Reproduce:

  1. Hover a line that was committed via a pull request in Bitbucket Server < 7
  2. The part "pull request #" is clickable
  3. Hover a line that was committed via a pull request in Bitbucket Server >= 7
  4. The part "Pull request #" is not clickable
@smartinio smartinio added potential-bug triage Needs to be looked at labels Mar 29, 2022
@smartinio smartinio mentioned this issue Mar 29, 2022
Merged
7 tasks
eamodio pushed a commit that referenced this issue Mar 31, 2022
@eamodio
Fixes #1932: Ignores case for pull request autolink in Bitbucket Server
d5bbe3b
@eamodio eamodio self-assigned this Mar 31, 2022
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Mar 31, 2022
@eamodio eamodio added this to the Soon™ milestone Mar 31, 2022
@eamodio eamodio added needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Mar 31, 2022
@eamodio
Copy link
Member

eamodio commented Mar 31, 2022

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

eamodio added a commit that referenced this issue Mar 31, 2022
@eamodio
Fixes #1932 invalid comparison & only on windows
b0c39ed
@smartinio
Copy link
Author

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

Will do 👍

@smartinio
Copy link
Author

@eamodio Tested insider. Works! The link leads to the correct PR as well.
Screenshot 2022-04-02 at 12 42 33

@github-actions
Copy link

github-actions bot commented May 3, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2022
@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels May 4, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label May 16, 2022
@eamodio eamodio modified the milestones: Soon™, Shipped May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Milestone
Shipped
Development

Successfully merging a pull request may close this issue.

Fixes #1932: Ignores case for pull request autolink in Bitbucket Server
2 participants
@eamodio @smartinio