Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken repositories view #1936

Closed
mattklein123 opened this issue Mar 29, 2022 · 9 comments
Closed

Broken repositories view #1936

mattklein123 opened this issue Mar 29, 2022 · 9 comments
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@mattklein123
Copy link

I'm seeing the following error pop up and also show in the GitLens debug output:

TypeError: Chaining cycle detected for promise #<Promise>

None of the repositories in the repository view will expand correctly, though they do show up.

GitLens version: 12.0.5
Git version: 2.32.0

Version: 1.65.2
Commit: c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1
Date: 2022-03-10T15:36:26.048Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.13.0-39-generic

Example log output:

[2022-03-29 21:30:04.505] [  244] Repository(/home/mklein/Source/infra).access — failed • 2 ms
TypeError: Chaining cycle detected for promise #<Promise>

Let me know how I can help debug. Thank you!

@mattklein123 mattklein123 added potential-bug triage Needs to be looked at labels Mar 29, 2022
@eivind-hovedkvarteret
Copy link

Also experiencing this. I get a vscode notification in the bottom right saying Chaining cycle detected for promise #<Promise>
I'm on macOS Monterey 12.3 with vs code 1.65.2 and GitLens v12.0.5, git version 2.32.0 (Apple Git-132)
Refreshing the window fixes the issue, it seems. I suspect it might have something to do with my repo structure. It contains a (gitignored) symlink to a folder on an SMB volume, which happened to be unmounted when i encountered the error this time (not sure about in the past). I have now correctly added it to my login items, so i'll see if this pops up when i boot my computer tomorrow, when the SMB share should be loaded.
It's interesting to note that the issue went away by refreshing the window, even before i'd mounted the SMB share.

@eamodio
Copy link
Member

eamodio commented Mar 31, 2022

@mattklein123 Do you have any symlinks in your repository too?

Can both of you please enable debug logging by running from GitLens: Enable Debug Logging from the Command Palette (F1 or ctrl/cmd+shift+p). This will enable logging to the GitLens and GitLens (Git) channel in the Output pane.

Once enabled, please reproduce the issue, and attach the log from the both GitLens and GitLens (Git) channels.

Thank you!

@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Mar 31, 2022
@mattklein123
Copy link
Author

@mattklein123 Do you have any symlinks in your repository too?

Probably yes. I will try to get you more logs.

@eivind-hovedkvarteret
Copy link

I encountered this again today. My editor had two files open, call them File A and File B

GitLens output: https://pastebin.com/e9WEp3ys (I've censored the filename from this log, but it's referring to the file i was viewing, which was File A)
GitLens (Git) output:

[2022-04-05 09:41:18.148] [      6ms] [/Users/eivind/Documents/munki/munki-repo] git ls-files -- <File B>

(GitLens (Git) output only showed up after i closed File A, which brought focus to File B for the first time in the session)

The error notification popped up multiple times without ever writing anything to GitLens (Git). Here's what theGit output shows (sometimes, but not always, it seems) when this happens:

[2022-04-05T09:49:02.718Z] > git fetch --all [586ms]
[2022-04-05T09:49:02.743Z] > git symbolic-ref --short HEAD [6ms]
[2022-04-05T09:49:02.748Z] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/production refs/remotes/production [5ms]
[2022-04-05T09:49:02.754Z] > git remote --verbose [5ms]
[2022-04-05T09:49:02.754Z] > git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname) [5ms]
[2022-04-05T09:49:02.759Z] > git config --get commit.template [4ms]
[2022-04-05T09:49:03.812Z] > git symbolic-ref --short HEAD [6ms]
[2022-04-05T09:49:03.818Z] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/production refs/remotes/production [6ms]
[2022-04-05T09:49:03.824Z] > git remote --verbose [5ms]
[2022-04-05T09:49:03.824Z] > git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname) [6ms]
[2022-04-05T09:49:03.830Z] > git config --get commit.template [5ms]
[2022-04-05T09:49:03.900Z] > git ls-files --stage -- /Users/eivind/Documents/munki/munki-repo/<file> [6ms]
[2022-04-05T09:49:03.906Z] > git cat-file -s a522cab77b0b7237bbb183e0efd11b4fe0134e65 [5ms]

@github-actions github-actions bot added the inactive Issue has not had recent required feedback label Apr 13, 2022
@gitkraken gitkraken deleted a comment from github-actions bot Apr 13, 2022
@eamodio eamodio added triage Needs to be looked at and removed needs-more-info Needs further information, steps, details, etc. labels Apr 13, 2022
@eamodio
Copy link
Member

eamodio commented Apr 13, 2022

Can you try to see if the issue is still reproducible in the GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@artemisSystem
Copy link

Just ran into this as well, on gitlens insiders v2022.4.1302

Here's my GitLens debug output:

[2022-04-23 11:44:40.153] [  14c] RepositoryNode(gitlens:repository(<my repository>)).ensureSubscription
[2022-04-23 11:44:40.153] [  14c] RepositoryNode(gitlens:repository(<my repository>)).ensureSubscription completed • 0 ms
[2022-04-23 11:44:40.157] [  14d] RepositoryNode(gitlens:repository(<my repository>)).ensureSubscription
[2022-04-23 11:44:40.157] [  14d] RepositoryNode(gitlens:repository(<my repository>)).ensureSubscription completed • 0 ms
[2022-04-23 11:44:40.157] [  14e] GitProviderService.getRemotesWithProviders — s=<my repository>
[2022-04-23 11:44:40.157] [  14f] GitProviderService.getRepository — s=<my repository>
[2022-04-23 11:44:40.157] [  14f] GitProviderService.getRepository returned <my repository> • 0 ms
[2022-04-23 11:44:40.157] [  150] GitProviderService.getRemotesWithProviders — s=<my repository>
[2022-04-23 11:44:40.157] [  151] GitProviderService.getRepository — s=<my repository>
[2022-04-23 11:44:40.157] [  151] GitProviderService.getRepository returned <my repository> • 0 ms
[2022-04-23 11:44:40.157] [  152] Repository(<my repository>).access — ue=worktrees
[2022-04-23 11:44:40.157] [  14e] GitProviderService.getRemotesWithProviders completed • 0 ms
[2022-04-23 11:44:40.157] [  150] GitProviderService.getRemotesWithProviders completed • 0 ms
[2022-04-23 11:44:40.157] [  152] Repository(<my repository>).access — failed • 0 ms
TypeError: Chaining cycle detected for promise #<Promise>

@eamodio eamodio self-assigned this Apr 27, 2022
@eamodio eamodio added bug Something isn't working and removed potential-bug inactive Issue has not had recent required feedback triage Needs to be looked at labels Apr 27, 2022
@eamodio eamodio added this to the Soon™ milestone Apr 27, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for community verification labels Apr 27, 2022
@eamodio
Copy link
Member

eamodio commented Apr 27, 2022

Sorry for the delay on this one -- took me a bit to track down.

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@eivind-hovedkvarteret
Copy link

I've installed v2022.4.2705 and not ran into the issue so far, at least. Annoyingly, i never found a reliable repro, so i can't be 100% certain the fix worked, but if it doesn't happen in the next few days it's probably fine

@eamodio eamodio modified the milestones: Soon™, June 2022 May 16, 2022
@eamodio eamodio modified the milestones: June 2022, 12.0.7 May 25, 2022
@eamodio eamodio added verified ✔ Verified and removed pending-release Resolved but not yet released to the stable edition needs-verification Request for community verification labels May 25, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

4 participants