Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch names with special characters like ';$|>' causes errors on the command line (terminal executed git commands) #2028

Closed
eamodio opened this issue Jun 10, 2022 · 1 comment
Closed

Branch names with special characters like ';$|>' causes errors on the command line (terminal executed git commands) #2028

eamodio opened this issue Jun 10, 2022 · 1 comment
Assignees
@eamodio
Labels
bug Something isn't working
Milestone
12.1

Comments

@eamodio
Copy link
Member

eamodio commented Jun 10, 2022

Originally reported by @mcy-kylin here

Open local clone repository with vscode; Create new branch and input name include ; $ | > &, not tips like xxxx isn't a valid branch name; There special characters are supported like git check-ref-format --branch , but run it with command line will occur exception for example, input branch name test;cd, run git branch test;cd master actually, same case branch name include $ | > & ;characters.

Add filter string include ; $ | > & characters function at check_ref_format ，avoid unknown exceptions when run git branch xxx commond.
@eamodio eamodio added potential-bug triage Needs to be looked at labels Jun 10, 2022
@eamodio eamodio self-assigned this Jun 10, 2022
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Jun 10, 2022
@eamodio eamodio added this to the 12.1 milestone Jun 10, 2022
mcy-kylin pushed a commit to mcy-kylin/vscode-gitlens that referenced this issue Jun 11, 2022
Fixes gitkraken#2028 quotes args with special characters
2bb8605
mcy-kylin pushed a commit to mcy-kylin/vscode-gitlens that referenced this issue Jun 11, 2022
branch names with special characters '<' also causes errors on the co…
245051f 
…mmand line like gitkraken#2028
@mcy-kylin mcy-kylin mentioned this issue Jun 11, 2022
Merged
7 tasks
eamodio pushed a commit that referenced this issue Jun 13, 2022
@eamodio
branch names with special characters '<' also causes errors on the co…
831a976 
…mmand line like #2028
@eamodio eamodio mentioned this issue Jun 13, 2022
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Something isn't working
Projects
None yet
Milestone
12.1
Development

No branches or pull requests
1 participant
@eamodio