Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autolinks can end up getting saved with invalid (cached) properties #2037

Closed
eamodio opened this issue Jun 14, 2022 · 1 comment
Closed

Autolinks can end up getting saved with invalid (cached) properties #2037

eamodio opened this issue Jun 14, 2022 · 1 comment
Assignees
@eamodio
Labels
bug Something isn't working
Milestone
12.1.1

Comments

@eamodio
Copy link
Member

eamodio commented Jun 14, 2022

Steps to Reproduce:

  1. Create a valid autolink, e.g. JIRA- and point it to some URL
  2. Create a commit that references that autolink, e.g. Fixes JIRA-123
  3. Hover over a line changed by the above commit and observe that the autolink will get saved with an invalid property (one of our added cached properties).
@eamodio eamodio added the bug Something isn't working label Jun 14, 2022
@eamodio eamodio self-assigned this Jun 14, 2022
@eamodio eamodio added this to the 12.1.1 milestone Jun 14, 2022
eamodio added a commit that referenced this issue Jun 15, 2022
@eamodio
Copies only known properties from autolinks
1dcf1bd 
Refs #2037
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Something isn't working
Projects
None yet
Milestone
12.1.1
Development

No branches or pull requests
1 participant
@eamodio