Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gerrit like urls for remotes #720

Closed
chun-wang opened this issue Apr 19, 2019 · 9 comments · Fixed by #1535
Closed

Support Gerrit like urls for remotes #720

chun-wang opened this issue Apr 19, 2019 · 9 comments · Fixed by #1535
Assignees
Labels
feature New feature or request help wanted Want community input and/or pull request needs-champion Needs a community champion to move this forward verified ✔ Verified
Milestone

Comments

@chun-wang
Copy link

chun-wang commented Apr 19, 2019

Need tokens like changes、changeId、patch set for remotes url config

@eamodio
Copy link
Member

eamodio commented Apr 19, 2019

I'm not at all familiar with Gerrit, but I would welcome a PR for this.

@eamodio eamodio added needs-champion Needs a community champion to move this forward help wanted Want community input and/or pull request feature New feature or request labels Apr 19, 2019
@eamodio eamodio added this to the Backlog milestone Apr 19, 2019
@andrewsavage1
Copy link
Contributor

I'm willing to pick this up, but I'm curious what Gerrit-specific features people are actually interested in—i.e. patch sets seem like a strange thing to integrate into gitlens imo.

Supporting the basics like Change Ids would be pretty simple though.

@andrewsavage1
Copy link
Contributor

I'll start with implementing basic support:

  • Adding Gerrit as a supported type extending RemoteProvider with GerritRemote
  • Being able to recognize and link Change Ids in the commit body

andrewsavage1 added a commit to andrewsavage1/vscode-gitlens that referenced this issue Jun 4, 2021
eamodio pushed a commit to andrewsavage1/vscode-gitlens that referenced this issue Nov 17, 2021
eamodio pushed a commit to andrewsavage1/vscode-gitlens that referenced this issue Nov 17, 2021
@eamodio eamodio self-assigned this Nov 17, 2021
@eamodio eamodio modified the milestones: Backlog, Soon™ Nov 17, 2021
eamodio pushed a commit that referenced this issue Nov 17, 2021
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Nov 17, 2021
@eamodio
Copy link
Member

eamodio commented Nov 17, 2021

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@heartacker
Copy link

@chun-wang could you please tell us a simple SOP how to work with gerrit.

@andrewsavage1
Copy link
Contributor

@eamodio Sorry I missed this, I'll verify it tomorrow.

@andrewsavage1
Copy link
Contributor

I've verified that this is working as expected in the Gitlens insiders edition!

@eamodio
Copy link
Member

eamodio commented Nov 19, 2021

Thank you!

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Nov 19, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Nov 19, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request help wanted Want community input and/or pull request needs-champion Needs a community champion to move this forward verified ✔ Verified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants