Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to disable all welcome screens. Fixes #1049. #1258

Merged
merged 2 commits into from Dec 14, 2020

Conversation

rickardp
Copy link
Contributor

@rickardp rickardp commented Dec 10, 2020

Description

Issue #1049 is about disabling all welcome screens altogether, including both the first-launch and the major-update. These become very annoying when used inside development containers and/or GitHub codespaces as this type of state is typically lost several times a day.

I made the choice to disable all welcome screens with one setting (leaving the "what's new" setting unchanged). The reasoning is that, for my use case above, I would prefer to just disable all the "advertising", current and future, with one setting that I could add to the devcontainer.json of my repos.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@rickardp rickardp mentioned this pull request Dec 10, 2020
@eamodio eamodio self-assigned this Dec 14, 2020
Ensures proper logging of startup
Updates description
@eamodio eamodio merged commit b30f4bc into gitkraken:main Dec 14, 2020
@eamodio
Copy link
Member

eamodio commented Dec 14, 2020

Thank you for your contribution!

Thank you

@eamodio
Copy link
Member

eamodio commented Dec 15, 2020

FYI, I changed the setting to be gitlens.showWelcomeOnInstall and only affect the welcome experience on the first install. If you also want to disable the What's New notification you will also need to change the existing gitlens.showWhatsNewAfterUpgrades setting.

@rickardp rickardp deleted the hide-welcome-screen-setting branch December 15, 2020 19:44
@rickardp rickardp restored the hide-welcome-screen-setting branch December 15, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants