Fixes #1303: Fix remote URLs for Azure DevOps #1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Fixes #1303
Remove the encoding to prevent double encoding for Azure DevOps URLs, to avoid these URLs from being 404 URLs.
Backstory:
When we added encodeURI() wrappers in 545dc4a, this caused a double-encoding problem with Azure DevOps URLs.
The problem exists in two places:
%20
. After being run through encodeURI(), this was changed to%2520
which resulted in a 404.%2F
instead of the/
. After being run through encodeURI(), these were being changed to%252F
, again resulting in a 404/
. After passing through encodeURI, this remains untouched as/
which works fine with Azure DevOps.Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses