New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1257 - Adds commit ordering option #1344
Conversation
@thewindsofwinter Overall this looks great -- thanks for the contribution! I wonder now though, if we should change this setting to be sort of a |
Hello! I'm glad it looks great, and I think in time I should be able to implement the rest in due time. I was wondering if we should merge this (to address laanwj's issue) and then I can create a new issue for what you suggested. School's started up for me so it might take me some time to change the setting, so I thought it might be better to first have this requested feature and then edit the rest later. Overall it's your call. Thank you for your time, and I'm glad I didn't mess anything up as of yet :D If there's anything I could improve on please let me know, I'm quite new to this! |
No worries if you don't have time. I don't want to merge this in directly and then have to change the settings, but I can add on to this PR to add those features, and then merge it. Thanks again for your contribution!! |
Alright, thank you for your time in reviewing this! |
@eamodio I updated @thewindsofwinter code and added some more code for the option you mentioned. Please have a look here: #1421. This is my first time contributing, so do let me know if I did something wrong. Thanks, |
Thank you! Sorry I couldn't get to it sooner |
Updates CHANGELOG
…oses gitkraken#1257: option to use commitOrdering - commitOrdering setting will now allow to order the commits by date, author or topo.
…CommitOrdering to set --topo-order flag
…oses gitkraken#1257: option to use commitOrdering - commitOrdering setting will now allow to order the commits by date, author or topo.
@thewindsofwinter @Shashank-Shastri Thank you so much for your contributions! |
Description
Closes #1257 - Adds topological ordering option for the git log command. See the issue for details.
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses