Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1257 - Adds commit ordering option #1344

Merged
merged 5 commits into from Mar 29, 2021

Conversation

thewindsofwinter
Copy link
Contributor

@thewindsofwinter thewindsofwinter commented Jan 26, 2021

Description

Closes #1257 - Adds topological ordering option for the git log command. See the issue for details.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio
Copy link
Member

eamodio commented Feb 1, 2021

@thewindsofwinter Overall this looks great -- thanks for the contribution! I wonder now though, if we should change this setting to be sort of a gitlens.advanced.commitOrdering, which could be one of null (the default), date, author-date, topo, and then each callsite would take an ordering flag. What do you think?

@thewindsofwinter
Copy link
Contributor Author

@thewindsofwinter Overall this looks great -- thanks for the contribution! I wonder now though, if we should change this setting to be sort of a gitlens.advanced.commitOrdering, which could be one of null (the default), date, author-date, topo, and then each callsite would take an ordering flag. What do you think?

Hello! I'm glad it looks great, and I think in time I should be able to implement the rest in due time. I was wondering if we should merge this (to address laanwj's issue) and then I can create a new issue for what you suggested. School's started up for me so it might take me some time to change the setting, so I thought it might be better to first have this requested feature and then edit the rest later.

Overall it's your call. Thank you for your time, and I'm glad I didn't mess anything up as of yet :D If there's anything I could improve on please let me know, I'm quite new to this!

@eamodio
Copy link
Member

eamodio commented Feb 2, 2021

No worries if you don't have time. I don't want to merge this in directly and then have to change the settings, but I can add on to this PR to add those features, and then merge it. Thanks again for your contribution!!

@thewindsofwinter
Copy link
Contributor Author

Alright, thank you for your time in reviewing this!

@Shashank-Shastri
Copy link
Contributor

@eamodio I updated @thewindsofwinter code and added some more code for the option you mentioned. Please have a look here: #1421. This is my first time contributing, so do let me know if I did something wrong.

Thanks,
Shashank

@thewindsofwinter
Copy link
Contributor Author

@eamodio I updated @thewindsofwinter code and added some more code for the option you mentioned. Please have a look here: #1421. This is my first time contributing, so do let me know if I did something wrong.

Thanks,
Shashank

Thank you! Sorry I couldn't get to it sooner

eamodio pushed a commit to thewindsofwinter/vscode-gitlens that referenced this pull request Mar 29, 2021
…oses gitkraken#1257: option to use commitOrdering

- commitOrdering setting will now allow to order the commits by date, author or topo.
thewindsofwinter and others added 3 commits March 28, 2021 22:58
…oses gitkraken#1257: option to use commitOrdering

- commitOrdering setting will now allow to order the commits by date, author or topo.
@eamodio eamodio changed the title Closes #1257 - Adds topological ordering option for git log Closes #1257 - Adds commit ordering option Mar 29, 2021
@eamodio eamodio merged commit ec219a1 into gitkraken:main Mar 29, 2021
@eamodio eamodio added this to the Soon™ milestone Mar 29, 2021
@eamodio eamodio self-assigned this Mar 29, 2021
@eamodio
Copy link
Member

eamodio commented Mar 29, 2021

@thewindsofwinter @Shashank-Shastri

Thank you so much for your contributions!

Thank you!

@eamodio eamodio modified the milestones: Soon™, Shipped Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to list commits in topological order
3 participants