Fixes #1562: fixes version of trim-newlines#1563
Merged
eamodio merged 1 commit intogitkraken:mainfrom Jul 2, 2021
Merged
Conversation
trim-newlines is a transitive dependency which is present in a dependency tree through imagemin-webp and node-sass. Version of trim-newlines which is referenced by those pacakges has a security advisory https://snyk.io/vuln/SNYK-JS-TRIMNEWLINES-1298042 Neither imagemin-webp nor node-sass have version which depend on patched version of trim-newlines. And at least node-sass is not maintained any longer. Under current circumstances the only way to fix this is to force trim-newlines version via "resolutions". As interface of the package is backward compatible and does not break anything I believe it is a right thing to do.
ivolzhevbt
force-pushed
the
security-fixes
branch
from
cb9135b to
0b9b06b
Compare
ivolzhevbt
changed the title
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi maintainers! I'm Ivan and I work at Bison Trails. We're doing an internal hackathon this week.
Our team loves vscode-gitlens, but it got flagged during a recent security review. Our team voted to use our hackathon time to patch vulnerabilities in our favorite OSS tools and specifically to try to get vscode-gitlens approved for usage within our organization.
What's here:
Impact:
These changes should improve vscode-gitlens's security posture. We identified these vulnerabilities using Salus and the OSSF scorecard. The specific issues I am hoping to address here are:
Thank you so much for your work maintaining vscode-gitlens, and thank you for taking the time to look at these proposed changes!
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses