Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1131 - "Search Commits" allows free term at search end #1575

Merged
merged 1 commit into from Nov 3, 2021

Conversation

Git-Lior
Copy link
Contributor

@Git-Lior Git-Lior commented Jul 10, 2021

Description

Fixes #1131

Before this change, it was assumed (in searchMessageOperationRegex) that only the text before the search operations can be a free-text term.

With this change, we look for the free-text term in two places:

  • before the first search operation (if none - the entire search is free-text)
    i.e: hello world author: abc def is interpreted as message:"hello world", author: "abc def"
  • after the first message value (respecting double-quotes) of the last search operation.
    i.e: author: abc def hello world is interpreted as author: "abc", message: "def hello world"
    to get the same result as before with this format, the search should be: author: "abc def" hello world
    (this rule only applies if there is no free-text at the start of the search)

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio eamodio self-assigned this Nov 3, 2021
@eamodio eamodio added this to the Soon™ milestone Nov 3, 2021
@eamodio eamodio merged commit 126ebf0 into gitkraken:main Nov 3, 2021
@eamodio
Copy link
Member

eamodio commented Nov 3, 2021

Awesome! Thank you so much for your contribution!

Thank you!

@eamodio eamodio modified the milestones: Soon™, Shipped Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order matters for search filters in 'search commits'
2 participants