Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1511: Double the size of the Avatar #1595

Merged
merged 2 commits into from Nov 4, 2021

Conversation

adaex
Copy link
Contributor

@adaex adaex commented Jul 28, 2021

ref #1511

Description

I tried to solve the problem that the avatar of the retina screen is very blurred, but I don't think I did well.

I am not particularly familiar with vscode plugin development. I don't know how to judge whether the current screen is a retinal screen, at the same time, it is not sure whether directly doubling the size of the avatar will cause other problems.

If I bring trouble to you, please forgive me. I really hope someone can help.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio eamodio self-requested a review November 3, 2021 06:31
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent approach, but we should move your fix here.

Add size *= 2; to before line 77 below
https://github.com/Axosoft/vscode-gitlens/blob/36de8cf5451b609c3596570540f60c645b0dc943/src/avatars.ts#L75-L77

@adaex
Copy link
Contributor Author

adaex commented Nov 3, 2021

@eamodio Updated. PTAL

@eamodio eamodio self-assigned this Nov 4, 2021
@eamodio eamodio added this to the Soon™ milestone Nov 4, 2021
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@eamodio eamodio merged commit d8dbf25 into gitkraken:main Nov 4, 2021
@eamodio
Copy link
Member

eamodio commented Nov 4, 2021

Thank you so much for your contribution!

Thank you!

@adaex adaex deleted the fix-avatar-size branch November 4, 2021 06:00
@eamodio eamodio modified the milestones: Soon™, Shipped Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants