Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch names with special characters '<' also causes errors on the co… …mmand line like #2028 #2030

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

mcy-kylin
Copy link

Description

branch names with special characters '<' also causes errors on the co…
…mmand line like #2028

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report and contribution!

The changes in src/env/node/git/git.ts aren't needed -- since they are valid branch names, just the change in repository.ts is required.

@mcy-kylin
Copy link
Author

Thanks for the report and contribution!

The changes in src/env/node/git/git.ts aren't needed -- since they are valid branch names, just the change in repository.ts is required.

Okay

@eamodio
Copy link
Member

eamodio commented Jun 11, 2022

So if you want to undo that change, and just leave the < change, I can merge this in.

@mcy-kylin
Copy link
Author

So if you want to undo that change, and just leave the < change, I can merge this in.

sorry i forgot to undo it

@eamodio
Copy link
Member

eamodio commented Jun 13, 2022

Thank you for your contribution!

Thank you

@eamodio eamodio added this to the 12.1 milestone Jun 13, 2022
@eamodio eamodio self-assigned this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants