Skip to content

Add Discussions model and api #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2018
Merged

Add Discussions model and api #279

merged 2 commits into from
Dec 12, 2018

Conversation

filippobuletto
Copy link
Contributor

Discussions are set of related notes on snippets, issues, epics, merge requests or commits.

This commit only include merge requests one.

@filippobuletto
Add Discussions model and api
6ca864f 
Discussions are set of related notes on snippets, issues, epics, merge
requests or commits.

This commit only include merge requests one.
@filippobuletto filippobuletto mentioned this pull request Dec 10, 2018
Closed
gmessner
gmessner requested changes Dec 10, 2018
View reviewed changes
Copy link
Collaborator

@gmessner gmessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filippobuletto
Thanks for the contribution. You'll find some requested changes in the comments.

@gmessner
Copy link
Collaborator

@filippobuletto
If you would prefer, I can go ahead and merge this and make the requested changes myself. I will also add the other methods from the Discussions API when doing so.

@filippobuletto
Copy link
Contributor Author

It's OK to me if you want to merge and complete the changes! Thank you for the suggestions, meanwhile I'll stick to my local changes until you complete the missing api 👍

@gmessner gmessner merged commit a852499 into gitlab4j:master Dec 12, 2018
gmessner added a commit that referenced this pull request Dec 13, 2018
@gmessner
Initial commit (#279).
4bd96b6
gmessner added a commit that referenced this pull request Dec 13, 2018
@gmessner
Mods to support and test Discussions API (#279).
d9c722a
@gmessner
Copy link
Collaborator

@filippobuletto
4.9.3 has been released with the new DiscussionsApi.

gmessner added a commit that referenced this pull request Dec 14, 2018
@gmessner
Added getDiscussionsApi() (#279).
d1f61ec
@gmessner
Copy link
Collaborator

@filippobuletto
Just realized that GitLabApi had not been modified to supply the DiscussionsApi instance. This has been fixed and released in 4.9.5. Example use:

List<Discussion> mrDiscussions = gitLabApi.getDiscussionsApi().getMergeRequestDiscussions(projectId, mergeRequestIid);

gmessner added a commit that referenced this pull request Dec 15, 2018
@gmessner
Initial commit (#279).
7805e15
gmessner added a commit that referenced this pull request Dec 15, 2018
@gmessner
Changed the type for notableType to String (#279).
30dc929
gmessner added a commit that referenced this pull request Dec 15, 2018
@gmessner
Added test for getting all discussions by list (#279).
d0d2cf0
@filippobuletto filippobuletto deleted the feature/add-discussion-model-api branch December 15, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmessner gmessner gmessner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filippobuletto @gmessner