From fea8d1c942b0b27e080877b12e732230901070f7 Mon Sep 17 00:00:00 2001 From: Philippe Vienne Date: Fri, 7 Jun 2019 16:13:55 +0200 Subject: [PATCH] Corrected scopes for impersonation tokens (#374) --- src/main/java/org/gitlab4j/api/models/ImpersonationToken.java | 2 +- src/test/java/org/gitlab4j/api/TestUserApi.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/gitlab4j/api/models/ImpersonationToken.java b/src/main/java/org/gitlab4j/api/models/ImpersonationToken.java index d0032a206..4e841aa84 100644 --- a/src/main/java/org/gitlab4j/api/models/ImpersonationToken.java +++ b/src/main/java/org/gitlab4j/api/models/ImpersonationToken.java @@ -14,7 +14,7 @@ public class ImpersonationToken { /** Enum to specify the scope of an ImpersonationToken. */ public enum Scope { - API, READ_USER; + API, READ_USER, READ_REPOSITORY, WRITE_REPOSITORY, READ_REGISTRY, SUDO; private static JacksonJsonEnumHelper enumHelper = new JacksonJsonEnumHelper<>(Scope.class); diff --git a/src/test/java/org/gitlab4j/api/TestUserApi.java b/src/test/java/org/gitlab4j/api/TestUserApi.java index 0e8ce0603..cb036bc7a 100644 --- a/src/test/java/org/gitlab4j/api/TestUserApi.java +++ b/src/test/java/org/gitlab4j/api/TestUserApi.java @@ -214,13 +214,13 @@ public void testSudoAsUser() throws GitLabApiException { public void testCreateImpersonationToken() throws GitLabApiException, ParseException { User user = gitLabApi.getUserApi().getCurrentUser(); - Scope[] scopes = {Scope.API, Scope.READ_USER}; + Scope[] scopes = {Scope.API, Scope.READ_USER, Scope.READ_REGISTRY, Scope.WRITE_REPOSITORY, Scope.SUDO}; Date expiresAt = ISO8601.toDate("2018-01-01T00:00:00Z"); ImpersonationToken token = gitLabApi.getUserApi().createImpersonationToken(user.getId(), TEST_IMPERSONATION_TOKEN_NAME, expiresAt, scopes); assertNotNull(token); assertNotNull(token.getId()); assertEquals(TEST_IMPERSONATION_TOKEN_NAME, token.getName()); - assertEquals(2, token.getScopes().size()); + assertEquals(5, token.getScopes().size()); gitLabApi.getUserApi().revokeImpersonationToken(user.getId(), token.getId()); }