Skip to content

Fix #411 Missing merged_at in merge request #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2019
Merged

Fix #411 Missing merged_at in merge request #412

merged 1 commit into from
Jul 22, 2019

Conversation

@lesiak
Copy link
Contributor

@lesiak lesiak commented Jul 19, 2019

No description provided.

@lesiak lesiak mentioned this pull request Jul 19, 2019
Closed
@gmessner
Copy link
Collaborator

gmessner commented Jul 19, 2019 •
edited
Loading

@lesiak
Missing and extra fields can be common because GitLab is constantly updating these messages. There are actually more fields missing than merged_at, following is a complete list of missing fields, could you change this PR to include all of them?

merged_by
merged_at
closed_by
closed_at
discussion_locked
allow_collaboration
allow_maintainer_to_push
time_stats
task_completion_status

The following field has been renamed:

merge_when_build_succeeds
    is now:
merge_when_pipeline_succeeds

The task_completion_status type does not exist, so it will need to be created.

Also, please make sure to update the following test file for MergeRequest:

src/test/resources/org/gitlab4j/api/merge-request.json

@lesiak
Fix gitlab4j#411 Added missing fields in merge_request
aee7f10 
- allow_collaboration
- allow_maintainer_to_push
- closed_at
- closed_by
- discussion_locked
- merged_at
- merged_by
- task_completion_status
- time_stats
renamed 
- merge_when_build_succeeds to merge_when_pipeline_succeeds
@lesiak
Copy link
Contributor Author

lesiak commented Jul 22, 2019

I amended the commit with all requested fields.
I also checked that closed_by and merged_by users are listed in the MR participants endpoint, so I used existing Participant type to represent them.

@gmessner
Copy link
Collaborator

gmessner commented Jul 22, 2019

@lesiak
Changes are spot on, thanks for making them. Should have a release out within a day.

@gmessner gmessner merged commit 02c9337 into gitlab4j:master Jul 22, 2019
@gmessner
Copy link
Collaborator

gmessner commented Jul 22, 2019

@lesiak
Version 4.11.18 has been released, thanks again for your contribution.

@lesiak lesiak deleted the 411-merged_at branch October 2, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lesiak @gmessner