Skip to content
This repository was archived by the owner on May 12, 2018. It is now read-only.

Conversation

@qfox
Copy link
Contributor

@qfox qfox commented Jan 28, 2013

Also --no-check-certificate added to wget tool (to prevent certificate warnings)

@jimothyGator
Copy link

I didn't get any certificate warnings running this command, and bypassing certificate checks could be dangerous. Someone could manipulate DNS entries and point you to a dangerous script that would run as root.

Whether that's likely to happen or not is debatable, but security checks seem like a good idea to me.

@qfox
Copy link
Contributor Author

qfox commented Mar 29, 2013

yeah. i'm wrong about certificate. better to check it by default
but restart is overpower here.

@jacobvosmaer
Copy link
Contributor

I also think you should remove the certificate override @zxqfox. Doing nginx reload instead of nginx restart may be nice if people are running GitLab CI on the same server as GitLab, for instance. What do you think @randx?

@qfox
Copy link
Contributor Author

qfox commented Jul 18, 2013

Seems like okay now.
@jacobvosmaer @randx what do you think?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 96a8905 on zxqfox:patch-2 into 5cbfd40 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 96a8905 on zxqfox:patch-2 into 5cbfd40 on gitlabhq:master.

jacobvosmaer added a commit that referenced this pull request Aug 19, 2013
Don't need restart nginx to reload configuration
@jacobvosmaer jacobvosmaer merged commit 164a1f5 into gitlabhq:master Aug 19, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants