[WIP] New repository structure #111

Merged
merged 42 commits into from Aug 22, 2013

Conversation

4 participants
@axilleas
Member

axilleas commented Aug 2, 2013

This is an attempt to give this repository the love it needs :)
During this point, there are three main groups for each functionality: init, install, web-server.

I won't merge any existing PRs because I've already come too far with the new structure, sorry guys. On the contrary I will cherry pick them and add them by hand. The PR number will appear on the commit message.

When this is finished I plan to merge it with master.

Please report anything you find that needs fixing or maybe an addition :)

TODO

  • Move guidelines to a contributing.md file in root dir.
  • Think a way to address script naming.
  • Guidelines for scripts that do similar things. Which to keep.
  • Add description in each README of main subdirs.

Pull Requests

  • systemd files #43, #14
  • Improve apache virtual host configuration #50 , #79
  • github to gitlab migration script #44
  • init.d script for centos 6.3 #58, #59 (check if this plays with version 5+)
  • Check Debian/Ubuntu install scripts #81, #82, #107, #108
  • CentOS init-script with rvm #96
  • Alternative solution for getting Nginx to work with gitlab on Centos #31
  • Check CentOS installation #62, #102, #105

Remember to

  • Add reference links to systemd services
  • Add info about contributors in systemd services
@jacobvosmaer

This comment has been minimized.

Show comment Hide comment
@jacobvosmaer

jacobvosmaer Aug 2, 2013

Member

Looks nice, keep it up!

Member

jacobvosmaer commented Aug 2, 2013

Looks nice, keep it up!

install/README.md
+Web Server : apache with mod_passenger
+Init system : systemd
+Contributor : thedude
+Additional Notes : the script installs `postgres` instead of `mysql` and user is `gitlab` instead of `git`

This comment has been minimized.

Show comment Hide comment
@jacobvosmaer

jacobvosmaer Aug 2, 2013

Member

Using user gitlab instead of git is generally not a good idea. Perhaps it would be better not to use such a scenario as an example?

@jacobvosmaer

jacobvosmaer Aug 2, 2013

Member

Using user gitlab instead of git is generally not a good idea. Perhaps it would be better not to use such a scenario as an example?

This comment has been minimized.

Show comment Hide comment
@axilleas

axilleas Aug 2, 2013

Member

You are right, I'll change it.

@axilleas

axilleas Aug 2, 2013

Member

You are right, I'll change it.

@ghost ghost assigned axilleas Aug 5, 2013

@JasonMing

This comment has been minimized.

Show comment Hide comment
@JasonMing

JasonMing Aug 8, 2013

Nice work ~ It's a good news for CentOS users.

Nice work ~ It's a good news for CentOS users.

@axilleas

This comment has been minimized.

Show comment Hide comment
@axilleas

axilleas Aug 8, 2013

Member

@JasonMing thanks :)
I have setup a CentOS VM and I will thoroughly check all the issues and refine the install guide. Hopefully will finish all testing till mid August.

Member

axilleas commented Aug 8, 2013

@JasonMing thanks :)
I have setup a CentOS VM and I will thoroughly check all the issues and refine the install guide. Hopefully will finish all testing till mid August.

@MrKeiKun

This comment has been minimized.

Show comment Hide comment
@MrKeiKun

MrKeiKun Aug 20, 2013

Requesting new update due to gitlabhq/gitlabhq@65cba5c

Requesting new update due to gitlabhq/gitlabhq@65cba5c

@axilleas

This comment has been minimized.

Show comment Hide comment
@axilleas

axilleas Aug 20, 2013

Member

@MrKeiKun I had it ready but didn't push :p

Member

axilleas commented Aug 20, 2013

@MrKeiKun I had it ready but didn't push :p

@MrKeiKun

This comment has been minimized.

Show comment Hide comment
@MrKeiKun

MrKeiKun Aug 20, 2013

push! :)

push! :)

@axilleas

This comment has been minimized.

Show comment Hide comment
@axilleas

axilleas Aug 22, 2013

Member

Ok time to merge. I'll deal with the remaining PRs afterwards.

Member

axilleas commented Aug 22, 2013

Ok time to merge. I'll deal with the remaining PRs afterwards.

axilleas added a commit that referenced this pull request Aug 22, 2013

@axilleas axilleas merged commit 1829ee3 into master Aug 22, 2013

@axilleas axilleas deleted the new_structure branch Aug 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment