Permalink
Browse files

improve regrex for match(sidekiq) robustness

e.g.: the sidekiq in my Debian box is v2.11.1
  • Loading branch information...
mhfan committed May 16, 2013
1 parent 886f7b6 commit dfe082fa1d3327c9bf6ee74a91f17044ff288150
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/tasks/gitlab/check.rake
@@ -588,7 +588,7 @@ namespace :gitlab do
def check_sidekiq_running
print "Running? ... "
if run_and_match("ps aux | grep -i sidekiq", /sidekiq \d\.\d\.\d.+$/)
if run_and_match("ps aux | grep -i sidekiq", /sidekiq \d+\.\d+\.\d+.+$/)
puts "yes".green
else
puts "no".red

1 comment on commit dfe082f

@slottermoser

This comment has been minimized.

Show comment
Hide comment
@slottermoser

slottermoser May 27, 2013

Contributor

Thank you for this. Fixed the false sidekiq running check failure I was getting on the rake check task.

Contributor

slottermoser commented on dfe082f May 27, 2013

Thank you for this. Fixed the false sidekiq running check failure I was getting on the rake check task.

Please sign in to comment.