Skip to content

Commit

Permalink
Make sure that tests pass when aws group is used.
Browse files Browse the repository at this point in the history
  • Loading branch information
maxlazio committed Apr 24, 2014
1 parent 1feaa33 commit fe1ca61
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 3 deletions.
3 changes: 2 additions & 1 deletion Gemfile
Expand Up @@ -71,6 +71,7 @@ gem "carrierwave"

# for aws storage
gem "fog", "~> 1.14", group: :aws
gem "unf", group: :aws

# Authorization
gem "six"
Expand Down Expand Up @@ -232,4 +233,4 @@ end

group :production do
gem "gitlab_meta", '6.0'
end
end
4 changes: 4 additions & 0 deletions Gemfile.lock
Expand Up @@ -531,6 +531,9 @@ GEM
execjs (>= 0.3.0)
json (>= 1.8.0)
underscore-rails (1.4.4)
unf (0.1.4)
unf_ext
unf_ext (0.0.6)
unicorn (4.6.3)
kgio (~> 2.6)
rack
Expand Down Expand Up @@ -659,6 +662,7 @@ DEPENDENCIES
turbolinks
uglifier
underscore-rails (~> 1.4.4)
unf
unicorn (~> 4.6.3)
unicorn-worker-killer
version_sorter
Expand Down
12 changes: 12 additions & 0 deletions config/initializers/carrierwave.rb
Expand Up @@ -18,4 +18,16 @@
config.fog_authenticated_url_expiration = 1 << 29 # optional time (in seconds) that authenticated urls will be valid.
# when fog_public is false and provider is AWS or Google, defaults to 600
end

# Mocking Fog requests, based on: https://github.com/carrierwaveuploader/carrierwave/wiki/How-to%3A-Test-Fog-based-uploaders
if Rails.env.test?
Fog.mock!
connection = ::Fog::Storage.new(
:aws_access_key_id => AWS_CONFIG['access_key_id'],
:aws_secret_access_key => AWS_CONFIG['secret_access_key'],
:provider => 'AWS',
:region => AWS_CONFIG['region']
)
connection.directories.create(:key => AWS_CONFIG['bucket'])
end
end
4 changes: 2 additions & 2 deletions spec/helpers/application_helper_spec.rb
Expand Up @@ -46,7 +46,7 @@
group = create(:group)
group.avatar = File.open(avatar_file_path)
group.save!
group_icon(group.path).to_s.should == "/uploads/group/avatar/#{ group.id }/gitlab_logo.png"
group_icon(group.path).to_s.should match("/uploads/group/avatar/#{ group.id }/gitlab_logo.png")
end

it "should give default avatar_icon when no avatar is present" do
Expand All @@ -63,7 +63,7 @@
user = create(:user)
user.avatar = File.open(avatar_file_path)
user.save!
avatar_icon(user.email).to_s.should == "/uploads/user/avatar/#{ user.id }/gitlab_logo.png"
avatar_icon(user.email).to_s.should match("/uploads/user/avatar/#{ user.id }/gitlab_logo.png")
end

it "should call gravatar_icon when no avatar is present" do
Expand Down

0 comments on commit fe1ca61

Please sign in to comment.