remove link instead of 403 no access #2495

Closed
tvb opened this Issue Jan 6, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@tvb

tvb commented Jan 6, 2013

If a user has no access to a page (ie commit page because user is type guest) remove the a href instead of showing 403 access denied page is much more user friendly imo. Therefore the link is not clickable at all.

@riyad

This comment has been minimized.

Show comment Hide comment
@riyad

riyad Jan 7, 2013

Contributor

Can you please be specific?

Contributor

riyad commented Jan 7, 2013

Can you please be specific?

@tvb

This comment has been minimized.

Show comment Hide comment
@tvb

tvb Jan 7, 2013

Sure. If a user has 'guest' permissions. He is not able to view the actual
commits as he is not allowed to view any code. But he is still able to
click on the commit ID link and instead of viewing the changes and code he
is redirected to the 403 not allowed page. My suggestion is to remove the
link for 'guest' permissions al together so the user is not triggered to
click a non-viewable commit and receive a useless page.

On Mon, Jan 7, 2013 at 7:56 PM, Riyad Preukschas
notifications@github.comwrote:

Can you please be specific?


Reply to this email directly or view it on GitHubhttps://github.com/gitlabhq/gitlabhq/issues/2495#issuecomment-11965065.

tvb commented Jan 7, 2013

Sure. If a user has 'guest' permissions. He is not able to view the actual
commits as he is not allowed to view any code. But he is still able to
click on the commit ID link and instead of viewing the changes and code he
is redirected to the 403 not allowed page. My suggestion is to remove the
link for 'guest' permissions al together so the user is not triggered to
click a non-viewable commit and receive a useless page.

On Mon, Jan 7, 2013 at 7:56 PM, Riyad Preukschas
notifications@github.comwrote:

Can you please be specific?


Reply to this email directly or view it on GitHubhttps://github.com/gitlabhq/gitlabhq/issues/2495#issuecomment-11965065.

@tvb

This comment has been minimized.

Show comment Hide comment
@tvb

tvb Jan 14, 2013

@riyad does the above make sense?

tvb commented Jan 14, 2013

@riyad does the above make sense?

@riyad

This comment has been minimized.

Show comment Hide comment
@riyad

riyad Jan 14, 2013

Contributor

@tristanvanbokkem I can't tell I've not yet come around to try it. ;) I'll answer as soon as I had the chance. ;)

Contributor

riyad commented Jan 14, 2013

@tristanvanbokkem I can't tell I've not yet come around to try it. ;) I'll answer as soon as I had the chance. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment