Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Project name can no longer contain ':' #2710

Closed
davidolrik opened this Issue Jan 23, 2013 · 2 comments

Comments

Projects
None yet
3 participants

The regex testing the project name have become too strict.

Please allow it to contain ':'.

Best regards David

cyvasse commented Jan 25, 2013

I think disallowing the ':' character is fine as a default, because it eases interoperability with Windows. The default regex should disallow the following characters in filenames to encourage people to name new repositories in ways that won't cause pain for Windows git clients:

<>:"\|?*

and ASCII control characters (ASCII codes 0-31). This list is from Microsoft.

But the regex of acceptable repository names should be configurable in the admin UI, so if more or less restrictive naming schemes are desired, they can be easily implemented by the app's administrator without changing it in the Gitlab code.

Agreed - I was only advocating for less strict project names.

Maybe a converter that translates non-filename-friendly characters to '-'.

@mikkyhouse mikkyhouse closed this Feb 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment