Dots in project names automatically parametrized. #2750

Closed
victorcoder opened this Issue Jan 24, 2013 · 6 comments

Comments

Projects
None yet
5 participants

Hi,

we just upgraded to 4.1 and we are used to name our repos with the client domain name, client.com, etc.

With 3.1 version we just were happy with the two textboxes that allows us to modify repo path and url, changing the suggested "_" for our preferred "."

But with this version, there's no more those textboxes. We were happy with that freedom to choose, and all our existing repos are working just find in 4.1 but new repos are being created with dashes "-" instead of dots "."

This is enforced here: https://github.com/gitlabhq/gitlabhq/blob/master/app/contexts/projects/create_context.rb#L13-L18

My question is, should be possible to restore back the old textboxes or it's dangerous for some reason to allow dots in pathnames and or urls inside gitlab?

Thanks.

Owner

randx commented Jan 24, 2013

we switched to parametrized algorithm in order to prevent any problems with validating path and parsing project url.
I agree that freedom of choise is improtant. But sometimes we use simplest solution to prevent bugs in future.

You can fork and restore old checkboxes but then we cannot guarantee a stability of application. It just may cause bugs

Contributor

koenpunt commented Jan 24, 2013

parameterize accepts an argument, the separator. Maybe this can be added as configuration option?

Thanks @randx I noticed that namespaced existing users is using email address and in my case we have everybody with dots in emails so the generater namespace urls could suffer from the same problem. Should be more consistent to parametrize namespaces too.

@koenpunt +1 My first action was to look at the config file.

Contributor

koenpunt commented Jan 28, 2013

And I could implement this, but not sure if it is correct to put this in config/gitlab.yml.. @randx Do you have a suggestion?

Contributor

koenpunt commented Jan 28, 2013

And speaking of the project path, my issue (#1143) also still exists

mikkyhouse closed this Feb 25, 2013

@stanhu stanhu added a commit that referenced this issue Dec 11, 2015

@stanhu stanhu Bump devise to 3.5.3 to fix reset token expiring after account creation
Also fixes an incorrect redirect after login with relative URL root:

Closes #8228

Closes #2750
7f1b60c

@randx randx added a commit that referenced this issue Dec 11, 2015

@randx randx Merge branch 'bump-devise-3.5.3' into 'master'
Bump devise to 3.5.3 to fix reset token expiring after account creation

Also fixes an incorrect redirect after login with relative URL root:

Closes #8228

Closes #2750

See merge request !2056
3a82302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment