Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Deploy keys: Key has already been taken #370

Closed
corpix opened this Issue Feb 3, 2012 · 18 comments

Comments

Projects
None yet
7 participants

corpix commented Feb 3, 2012

Why i can't have one key for multiple projects?

Contributor

vsizov commented Feb 4, 2012

you can make pull request always

corpix commented Feb 4, 2012

I'd be glad to do it, but I'm not Ruby/ROR developer

barockok commented Feb 5, 2012

bump

Nice feature! do you guys really generate a single unique ssh key per project?

Contributor

yvmarques commented Feb 6, 2012

I support this request, it's something very import to have the possibility to have one deploy key for multi-projects (on my case, I've some projects on the same server).

Contributor

miks commented Feb 6, 2012

For security reason it's better to have unique user for each of application on deploy (production) server.
If you have many projects under one user on deploy (production) server, then it's really easy to add new user to gitlabhq and give pull only access to projects you need.

Nice feature! do you guys really generate a single unique ssh key per project?

@miks, I think the whole point of having deploy keys is to avoid creating extra users in gitlab; or am I missing something here?

Contributor

miks commented Feb 6, 2012

I think it's not really hard to add one extra user and you have all user management features (add new projects from user view, user projects overview, etc).
Github also does not provide ability to have non-unique deploy keys.

Contributor

vsizov commented Feb 6, 2012

you can create fake user, who have only reader rules.

@vsizov I can indeed, but why have deploy keys at all then?

Contributor

miks commented Feb 7, 2012

It's for production environment.

@miks right, but what's wrong with allowing a single key for multiple projects? It's just a oneliner-fix in the code -- so there must be something wrong with it conceptually.

Contributor

miks commented Feb 7, 2012

I don't think that proper implementation is oneliner-fix. I will try to implement it later.

Hm, I think simply removing this line would work; or alternatively we can add a custom uniqueness validator, which makes sure a key is unique within a project.

Contributor

yvmarques commented Feb 7, 2012

@superbobry I'm not sure, but if you do it, it will not add the same key many times in the authorized_keys ?

Contributor

miks commented Feb 7, 2012

Nop. Gitolite need unique keys and therefore key exporting for gitolite need to be rewritten.

@corpix corpix closed this Mar 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment