Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Deploy keys: Key has already been taken #370

Closed
corpix opened this Issue · 18 comments

7 participants

@corpix

Why i can't have one key for multiple projects?

@vsizov
Collaborator

you can make pull request always

@corpix

I'd be glad to do it, but I'm not Ruby/ROR developer

@barock19

bump

@superbobry

Nice feature! do you guys really generate a single unique ssh key per project?

@yvmarques

I support this request, it's something very import to have the possibility to have one deploy key for multi-projects (on my case, I've some projects on the same server).

@miks

For security reason it's better to have unique user for each of application on deploy (production) server.
If you have many projects under one user on deploy (production) server, then it's really easy to add new user to gitlabhq and give pull only access to projects you need.

Nice feature! do you guys really generate a single unique ssh key per project?

@superbobry

@miks, I think the whole point of having deploy keys is to avoid creating extra users in gitlab; or am I missing something here?

@miks

I think it's not really hard to add one extra user and you have all user management features (add new projects from user view, user projects overview, etc).
Github also does not provide ability to have non-unique deploy keys.

@vsizov
Collaborator

you can create fake user, who have only reader rules.

@superbobry

@vsizov I can indeed, but why have deploy keys at all then?

@miks

It's for production environment.

@superbobry

@miks right, but what's wrong with allowing a single key for multiple projects? It's just a oneliner-fix in the code -- so there must be something wrong with it conceptually.

@miks

I don't think that proper implementation is oneliner-fix. I will try to implement it later.

@superbobry

Hm, I think simply removing this line would work; or alternatively we can add a custom uniqueness validator, which makes sure a key is unique within a project.

@yvmarques

@superbobry I'm not sure, but if you do it, it will not add the same key many times in the authorized_keys ?

@miks

Nop. Gitolite need unique keys and therefore key exporting for gitolite need to be rewritten.

@corpix corpix closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.