Change default routine for setting up an default admin account #7272

Closed
TimDaub opened this Issue Jul 7, 2014 · 6 comments

Projects

None yet

5 participants

@TimDaub
TimDaub commented Jul 7, 2014

Hi there,

first of all, I'm not particularly good in reading or writing ruby code but as I was installing gitlab and changing the administrator password, I noticed, that the default admin email was set to admin@local.host.

I googled around a little bit and found out about http://dothostregistry.com/.

So, if the latest version of gitlab still generates an admin account with admin@local.host, then I think this should be changed to not give anyone registering local.host the chance of exploiting gitlabs all over the world.

I found something about the email address in this file:

db/fixtures/production/001_admin.rb

@chendrix
chendrix commented Jul 7, 2014

👍 There's a reddit conversation happening about this now

@dosire
Member
dosire commented Jul 8, 2014

@Linkeex Good point! Shall we change it into admin@example.com? http://tools.ietf.org/html/rfc2606 ".example" is recommended for use in documentation or as examples.

@randx
Member
randx commented Jul 20, 2014

👍 for admin@example.com. I will push fix soon!

@randx
Member
randx commented Jul 20, 2014

Fixed by c86962e

@TimDaub
TimDaub commented Jul 20, 2014

thx 👍

@TimDaub TimDaub closed this Jul 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment