The gitlab.pub file probably shouldn't be world readable, but let's star... #1045

Merged
merged 1 commit into from Jul 16, 2012

Conversation

3 participants
@tobert
Contributor

tobert commented Jul 5, 2012

...t with just making it read-only and not executable.

The gitlab.pub file probably shouldn't be world readable, but let's s…
…tart with just making it read-only and not executable.

@ghost ghost assigned vsizov Jul 9, 2012

@peikk0

This comment has been minimized.

Show comment
Hide comment
@peikk0

peikk0 Jul 12, 2012

Contributor

The point with a public key is to be public, there is no security issue with it being readable by everyone.

Contributor

peikk0 commented Jul 12, 2012

The point with a public key is to be public, there is no security issue with it being readable by everyone.

@tobert

This comment has been minimized.

Show comment
Hide comment
@tobert

tobert Jul 12, 2012

Contributor

Sure, make it mode 0444 if you want it world readable. Making it mode 0777 means it's executable and world writable and that makes no sense.

Contributor

tobert commented Jul 12, 2012

Sure, make it mode 0444 if you want it world readable. Making it mode 0777 means it's executable and world writable and that makes no sense.

vsizov added a commit that referenced this pull request Jul 16, 2012

Merge pull request #1045 from tobert/patch-1
The gitlab.pub file probably shouldn't be world readable, but let's star...

@vsizov vsizov merged commit 244a1ca into gitlabhq:master Jul 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment