Skip to content

Conversation

@riyad
Copy link
Contributor

@riyad riyad commented Jul 22, 2012

Especially separating the commit title (first line) from the description (rest) makes for nicer and more consistent commit lists.

This is also in preparation for changes regarding #527

dzaporozhets added a commit that referenced this pull request Jul 25, 2012
@dzaporozhets dzaporozhets merged commit 5133541 into gitlabhq:master Jul 25, 2012
@dzaporozhets
Copy link
Contributor

do you run tests?

@riyad
Copy link
Contributor Author

riyad commented Jul 25, 2012

yes :-)

@riyad
Copy link
Contributor Author

riyad commented Jul 25, 2012

I even had to update one to make it pass ;-)

@dzaporozhets
Copy link
Contributor

forget to mention in wiki to run cucumber :)

On Wed, Jul 25, 2012 at 9:44 PM, Riyad Preukschas <
reply@reply.github.com

wrote:

yes :-)


Reply to this email directly or view it on GitHub:
#1127 (comment)

@dzaporozhets
Copy link
Contributor

cause commits compare failed

On Wed, Jul 25, 2012 at 9:44 PM, Dmitriy Zaporozhets <
dmitriy.zaporozhets@gmail.com> wrote:

forget to mention in wiki to run cucumber :)

On Wed, Jul 25, 2012 at 9:44 PM, Riyad Preukschas <
reply@reply.github.com

wrote:

yes :-)


Reply to this email directly or view it on GitHub:
#1127 (comment)

@riyad
Copy link
Contributor Author

riyad commented Jul 25, 2012

Oops ... forgot about cucumber :-(

@dzaporozhets
Copy link
Contributor

Ive pushed a fix but we should run cucumber in future PR

@riyad
Copy link
Contributor Author

riyad commented Jul 25, 2012

I'll definitely remember ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants