Skip to content

Conversation

@rspeicher
Copy link
Contributor

Might shave a few seconds off Travis builds.

dzaporozhets added a commit that referenced this pull request Aug 23, 2012
Don't run SimpleCov on Travis
@dzaporozhets dzaporozhets merged commit 07fe78b into gitlabhq:master Aug 23, 2012
@mikkyhouse
Copy link
Contributor

merged

On Thu, Aug 23, 2012 at 2:25 PM, Robert Speicher
notifications@github.comwrote:

Might shave a few seconds off Travis builds.

You can merge this Pull Request by running:

git pull https://github.com/tsigo/gitlabhq no_ci_simplecov

Or view, comment on, or merge it at:

#1275
Commit Summary

  • Don't run SimpleCov on Travis

File Changes

  • M features/support/env.rb (6)
  • M spec/spec_helper.rb (6)

Patch Links

@travisbot
Copy link

This pull request passes (merged db4c3e5 into ed2b53c).

dzaporozhets pushed a commit that referenced this pull request Mar 23, 2015
DouweM pushed a commit that referenced this pull request Mar 23, 2015
Include missing events and fix save functionality in admin service template settings form

### What does this MR do?

This MR includes missing settings left out in the Admin -> Service Templates page and fixes the inability to save certain settings.

### Are there points in the code the reviewer needs to double check?

No.

### Why was this MR needed?

Because the service template form was broken and untested.

### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?

#1275

Before:

![Screen_Shot_2015-03-23_at_5.53.19_AM](https://gitlab.com/stanhu/gitlab-ce/uploads/e1bff75f30a3b6ecb174d3e25c722b7e/Screen_Shot_2015-03-23_at_5.53.19_AM.png)

After:

![Screen_Shot_2015-03-23_at_5.53.13_AM](https://gitlab.com/stanhu/gitlab-ce/uploads/8fada00128a3d0951b3230fefa64be92/Screen_Shot_2015-03-23_at_5.53.13_AM.png)

See merge request !427
DouweM pushed a commit that referenced this pull request Mar 25, 2015
Include missing events and fix save functionality in admin service template settings form

### What does this MR do?

This MR includes missing settings left out in the Admin -> Service Templates page and fixes the inability to save certain settings.

### Are there points in the code the reviewer needs to double check?

No.

### Why was this MR needed?

Because the service template form was broken and untested.

### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?

#1275

Before:

![Screen_Shot_2015-03-23_at_5.53.19_AM](https://gitlab.com/stanhu/gitlab-ce/uploads/e1bff75f30a3b6ecb174d3e25c722b7e/Screen_Shot_2015-03-23_at_5.53.19_AM.png)

After:

![Screen_Shot_2015-03-23_at_5.53.13_AM](https://gitlab.com/stanhu/gitlab-ce/uploads/8fada00128a3d0951b3230fefa64be92/Screen_Shot_2015-03-23_at_5.53.13_AM.png)

See merge request !427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants