Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber => Spinach #1426

Merged
merged 11 commits into from Sep 10, 2012
Merged

Cucumber => Spinach #1426

merged 11 commits into from Sep 10, 2012

Conversation

NARKOZ
Copy link
Contributor

@NARKOZ NARKOZ commented Sep 10, 2012

@dzaporozhets
Copy link
Member

@NARKOZ its cool! You rock!

dzaporozhets added a commit that referenced this pull request Sep 10, 2012
@dzaporozhets dzaporozhets merged commit 3f01ec2 into gitlabhq:master Sep 10, 2012
@AlexDenisov
Copy link
Contributor

Looks like spinach is awesome tool :)

dzaporozhets added a commit that referenced this pull request Jul 23, 2014
Explore area

Fixes #1426

See merge request !987
@alwinmark
Copy link

Why did you move away from cucumber? For me spinach seems to have no advantages and it lacks of features to really reuse steps.

So at the and those steps are clustered in features files and steps (like in cucumber) without the ability to reuse them as they are to dedicated to one use case.

So either you are completely out of mind our I'm missing your point.

@alwinmark
Copy link

Also its very strange how you are using Gherkin:

You are never using When Statements... just Given and Then. You should only use Given if you are preparing the test and Then if you're checking the expecting behaviour. If a user is doing the actual tasks which are interesting for the test they should be wrapped with When Statements.

It's much clearer what a test should do, when it is failing if these conditions are clear.

@vsizov
Copy link
Contributor

vsizov commented Nov 29, 2016

Actually we are moving from spinach to rspec :) This issue is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants