Routing specs and cleanup #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It still works, and it cleans up the output of `rake routes`.
Also cleans up some alignment and removes unnecessary "to: " arguments
Handles stuff that's shared across admin controllers.
We were already calling `authorize_admin_issue!` in a before filter with the same permission checks, so this deleted check wasn't actually doing anything.
Uses TeamMembers#index instead, to be more RESTful
|
Wouldn't it be better to split the routing specs into one file per controller? |
|
Yeah, probably. I can do that if we want. |
|
I dunno, while there's definitely a downside to a file that big, I think there's definitely a positive side to seeing them all in one file; so many of them are related since they belong to Projects. There's probably a better way to split it up than just one file per controller. I'll think on it some more. |
|
I'll trust your jundgement. ;) |
|
That split them up a bit. |
dzaporozhets
added a commit
that referenced
this pull request
Sep 16, 2012
Routing specs and cleanup
|
@tsigo great cleanup. You make my dreams :) |
maxlazio
added a commit
that referenced
this pull request
Sep 16, 2014
API MR ordering Fixes #1477 See merge request !1076
dzaporozhets
pushed a commit
that referenced
this pull request
Apr 23, 2015
dzaporozhets
added a commit
that referenced
this pull request
Apr 23, 2015
Use `search_text_nodes` helper in our custom filters Closes #1477 See merge request !561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, this adds routing specs. Why? Because I was going to modify the
routes and wanted to make sure the current ones still worked after my
changes.
Then I made a few changes:
AdminControllerbase controller for the other Admincontrollers to subclass. It currently handles setting the layout and
authorizing an admin and just removes some duplication from those
controllers.
routes.rb, mostly 1.9 Hash syntax and alignment andspacing.
controllers.
actions but only used "show", for instance.)
uses the 'index' action in TeamMembers.