Remove backward compatibility of factories. #1928

Merged
merged 1 commit into from Nov 13, 2012

Conversation

Projects
None yet
4 participants
@kouno
Contributor

kouno commented Nov 6, 2012

Just a refactoring.

@riyad

This comment has been minimized.

Show comment Hide comment
@riyad

riyad Nov 6, 2012

Contributor

+1

Contributor

riyad commented Nov 6, 2012

+1

@rspeicher

This comment has been minimized.

Show comment Hide comment
@rspeicher

rspeicher Nov 6, 2012

Owner

Take this one step further and remove FactoryGirl. - we already mixin the FG syntax to all examples, so you can just do create(...), build(...), etc.

👍, I always intended to do this eventually.

Owner

rspeicher commented Nov 6, 2012

Take this one step further and remove FactoryGirl. - we already mixin the FG syntax to all examples, so you can just do create(...), build(...), etc.

👍, I always intended to do this eventually.

@dzaporozhets

This comment has been minimized.

Show comment Hide comment
@dzaporozhets

dzaporozhets Nov 7, 2012

Owner

+1 for build and create.

Owner

dzaporozhets commented Nov 7, 2012

+1 for build and create.

@kouno

This comment has been minimized.

Show comment Hide comment
@kouno

kouno Nov 7, 2012

Contributor

Rebased and changed it for create(), build().

Contributor

kouno commented Nov 7, 2012

Rebased and changed it for create(), build().

@dzaporozhets

View changes

features/steps/dashboard/dashboard_merge_requests.rb
@@ -17,6 +17,9 @@ class DashboardMergeRequests < Spinach::FeatureSteps
project1.add_access(@user, :read, :write)
project2.add_access(@user, :read, :write)
+ project1.add_access(@user, :read, :write)

This comment has been minimized.

Show comment Hide comment
@dzaporozhets

dzaporozhets Nov 9, 2012

Owner

why duplicate?

@dzaporozhets

dzaporozhets Nov 9, 2012

Owner

why duplicate?

This comment has been minimized.

Show comment Hide comment
@kouno

kouno Nov 9, 2012

Contributor

Hum. It's probably coming from the rebase. I did not want to add this.

@kouno

kouno Nov 9, 2012

Contributor

Hum. It's probably coming from the rebase. I did not want to add this.

dzaporozhets added a commit that referenced this pull request Nov 13, 2012

Merge pull request #1928 from kouno/cleanup-factories
Remove backward compatibility of factories.

@dzaporozhets dzaporozhets merged commit b28ab89 into gitlabhq:master Nov 13, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment