New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gems #1981

Merged
merged 2 commits into from Nov 19, 2012

Conversation

2 participants
@riyad
Contributor

riyad commented Nov 13, 2012

Updates a lot of Gems to their most up-to-date versions.

These have been pinned to the current (old) version:

  • shoulda-matchers was pinned to 1.3.0 because of thoughtbot/shoulda-matchers#179
  • bootstrap-sass was left unupdated, because it would need a lot of testing and style adjustments after the update
@dzaporozhets

This comment has been minimized.

Show comment
Hide comment
@dzaporozhets

dzaporozhets Nov 14, 2012

Member

yeah. bootstrap is a kind of gem we better keep outdated :)

Member

dzaporozhets commented Nov 14, 2012

yeah. bootstrap is a kind of gem we better keep outdated :)

@dzaporozhets

This comment has been minimized.

Show comment
Hide comment
@dzaporozhets

dzaporozhets Nov 16, 2012

Member

gemoji images 404 not found for development

Member

dzaporozhets commented Nov 16, 2012

gemoji images 404 not found for development

@riyad

This comment has been minimized.

Show comment
Hide comment
@riyad

riyad Nov 16, 2012

Contributor

Strange ... I'll have a look.

Contributor

riyad commented Nov 16, 2012

Strange ... I'll have a look.

@riyad

This comment has been minimized.

Show comment
Hide comment
@riyad

riyad Nov 16, 2012

Contributor

Rebased and updated. I had to add an initializer for Gemoji.

Contributor

riyad commented Nov 16, 2012

Rebased and updated. I had to add an initializer for Gemoji.

@riyad

This comment has been minimized.

Show comment
Hide comment
@riyad

riyad Nov 16, 2012

Contributor

The test failure is unrelated (also fails on master).

Contributor

riyad commented Nov 16, 2012

The test failure is unrelated (also fails on master).

@riyad

This comment has been minimized.

Show comment
Hide comment
@riyad

riyad Nov 18, 2012

Contributor

Updated and rebased again.

Contributor

riyad commented Nov 18, 2012

Updated and rebased again.

dzaporozhets added a commit that referenced this pull request Nov 19, 2012

@dzaporozhets dzaporozhets merged commit 36bbcc6 into gitlabhq:master Nov 19, 2012

1 check failed

default The Travis build failed
Details
@dzaporozhets

This comment has been minimized.

Show comment
Hide comment
@dzaporozhets

dzaporozhets Nov 20, 2012

Member

@riyad thanks for PR. Also i noticed a interesting issue - i get it randomly

Started GET "/admin" for 127.0.0.1 at 2012-11-20 14:50:06 +0000
Processing by Admin::DashboardController#index as HTML
Completed 500 Internal Server Error in 3ms

Redis::InheritedError (Tried to use a connection from a child process without reconnecting. You need to reconnect to Redis after forking.):
  app/controllers/admin/dashboard_controller.rb:3:in `index'


Member

dzaporozhets commented Nov 20, 2012

@riyad thanks for PR. Also i noticed a interesting issue - i get it randomly

Started GET "/admin" for 127.0.0.1 at 2012-11-20 14:50:06 +0000
Processing by Admin::DashboardController#index as HTML
Completed 500 Internal Server Error in 3ms

Redis::InheritedError (Tried to use a connection from a child process without reconnecting. You need to reconnect to Redis after forking.):
  app/controllers/admin/dashboard_controller.rb:3:in `index'


@riyad

This comment has been minimized.

Show comment
Hide comment
@riyad

riyad Nov 20, 2012

Contributor

I've been working with this for a week and didn't notice anything.

Contributor

riyad commented Nov 20, 2012

I've been working with this for a week and didn't notice anything.

@dzaporozhets

This comment has been minimized.

Show comment
Hide comment
@dzaporozhets

dzaporozhets Nov 20, 2012

Member

strange. I got it on production sometimes. I has another application running resque on same server. Maybe its a reason

Member

dzaporozhets commented Nov 20, 2012

strange. I got it on production sometimes. I has another application running resque on same server. Maybe its a reason

dzaporozhets pushed a commit that referenced this pull request Feb 12, 2015

dzaporozhets added a commit that referenced this pull request Feb 12, 2015

Merge branch 'ssh-link' into 'master'
Fix link to SSH help page.

Closes #1981.

See merge request !1502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment