Improve user feedback on the Profile > Design page #2030

Merged
merged 1 commit into from Nov 21, 2012

Conversation

3 participants
@rspeicher
Member

rspeicher commented Nov 21, 2012

  • Header changes immediately without a page reload
  • Lets the user know that we actually saved their setting when changed

Demo GIF:

Improve user feedback on the Profile > Design page
- Header changes immediately without a page reload
- Lets the user know that we actually saved their setting when changed
@riyad

This comment has been minimized.

Show comment Hide comment
@riyad

riyad Nov 21, 2012

Contributor

nice :)

Contributor

riyad commented Nov 21, 2012

nice :)

@dzaporozhets

This comment has been minimized.

Show comment Hide comment
@dzaporozhets

dzaporozhets Nov 21, 2012

Member

Cool. But Why erb ?

Member

dzaporozhets commented Nov 21, 2012

Cool. But Why erb ?

@rspeicher

This comment has been minimized.

Show comment Hide comment
@rspeicher

rspeicher Nov 21, 2012

Member

I dunno. Why not? I think for these kind of JavaScript views it's cleaner.

Member

rspeicher commented Nov 21, 2012

I dunno. Why not? I think for these kind of JavaScript views it's cleaner.

dzaporozhets added a commit that referenced this pull request Nov 21, 2012

Merge pull request #2030 from tsigo/theme_feedback
Improve user feedback on the Profile > Design page

@dzaporozhets dzaporozhets merged commit 7392d28 into gitlabhq:master Nov 21, 2012

1 check failed

default The Travis build failed
Details
@dzaporozhets

This comment has been minimized.

Show comment Hide comment
@dzaporozhets

dzaporozhets Nov 21, 2012

Member

Lets use haml everywhere

Member

dzaporozhets commented Nov 21, 2012

Lets use haml everywhere

@rspeicher rspeicher deleted the rspeicher:theme_feedback branch Jan 18, 2013

dzaporozhets added a commit that referenced this pull request Feb 20, 2015

Merge branch 'improve-web-hooks' into 'master'
Improve web hooks

* add git_http_url and git_ssh_url to project web hook
* add visibility_level to project web hook
* add documentation about project visibility_level in API

Fixes #2018, #2030

cc @sytse

See merge request !1560

dzaporozhets added a commit that referenced this pull request Feb 21, 2015

Merge branch 'improve-web-hooks' into 'master'
Improve web hooks

* add git_http_url and git_ssh_url to project web hook
* add visibility_level to project web hook
* add documentation about project visibility_level in API

Fixes #2018, #2030

cc @sytse

See merge request !1560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment