Remove SQLite support #2093

Merged
merged 1 commit into from Nov 27, 2012

Conversation

Projects
None yet
6 participants
Contributor

riyad commented Nov 27, 2012

Supporting SQLite makes no sense for GitLab:

  • SQLite shouldn't be used in production (because of mulit-user/multi-process access to DB)
  • Strange race conditions with SQL (e.g. #1262)
  • Problems with locking

It might be a good idea for starting development, but it shouldn't be supported in production.

vsizov added a commit that referenced this pull request Nov 27, 2012

@vsizov vsizov merged commit 99e1d9d into gitlabhq:master Nov 27, 2012

1 check was pending

default The Travis build is in progress
Details
Contributor

sodabrew commented Nov 28, 2012

Why? Please don't drop sqlite.

Contributor

riyad commented Nov 30, 2012

Because SQLite is not made for mulit-user/multi-process access which is almost always the case in production env. In contrast to MySQL or PostgreSQL there is no database process that an app can connect to which manages concurrent access to the data, but they have to "directly" (actually through the SQLite driver) manipulate the SQLite database file.
SQLite is made for embedding DBs in apps where you can make sure there is only one process accessing the DB. A web server is not such an environment.

Owner

dzaporozhets commented Nov 30, 2012

👍

I'm currently using gitlab with two other developers and haven't any problems with sqlite3 yet.
For bigger teams I would suggest to mysql/postgresql, but for smaller teams, sqlite3 is more than enough, isn't it?

Please reconsider this change :(

Contributor

koenpunt commented Dec 21, 2012

Migrating from sqlite to mysql is easy, using rails migrations. For an example on how to do this you can have look at this question at Stack Overflow

Contributor

koenpunt commented Dec 21, 2012

I also stumbled upon a page in the wiki about migrating: https://github.com/gitlabhq/gitlabhq/wiki/Migrate-from-SQLite-to-MySQL

Thanks for the links, but I know for sure, how to migrate from sqlite to mysql.

Using gitlab with mysql for a small team is just oversized, sqlite3 would fit there much better.

@dzaporozhets dzaporozhets referenced this pull request in gitlabhq/gitlab-ci Oct 30, 2014

Closed

Adding sqlite3 support #482

maxlazio added a commit that referenced this pull request Mar 4, 2015

Merge branch 'build_page_text' into 'master'
Changed to 'View Build Page'

Fixes #2093

Changes 'Build Page' to 'View build page'

See merge request !1626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment