-
Notifications
You must be signed in to change notification settings - Fork 5.8k
SCSS/CSS refactor #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCSS/CSS refactor #2110
Conversation
Fonts, variables and mixins are now all in their own stylesheets
… a colon and a space `: `
(there really should be some convention for all gitlab css)
…single standard for notation
|
In the scenario: |
|
First of all thank you! |
|
Ok, I can understand that. Should I split it in separate PR's? |
|
@koenpunt yes it will be great |
|
Closing this in favor of #2117 |
I could sum up al my commit messages here, but basically it comes down to a more uniform SCSS and some more declarative naming of mixins and variables.
And my main reason to do this; the clutter of different definitions of classnames on elements. Before half of all were separated with underscores
_and the other half with dashes-. Now its all dashes.Ultimately there should be some kind of code quality control in GitLab for SASS like https://github.com/twitter/recess for LESS