Skip to content

Conversation

@koenpunt
Copy link
Contributor

I could sum up al my commit messages here, but basically it comes down to a more uniform SCSS and some more declarative naming of mixins and variables.
And my main reason to do this; the clutter of different definitions of classnames on elements. Before half of all were separated with underscores _ and the other half with dashes -. Now its all dashes.

Ultimately there should be some kind of code quality control in GitLab for SASS like https://github.com/twitter/recess for LESS

@koenpunt
Copy link
Contributor Author

In the scenario: I change my application theme there is an failure which states expected css "body.ui-color" to return something, but redoing the steps described in the feature in the browser myself works well, so i'm not sure where the problem lies.

@dzaporozhets
Copy link
Contributor

First of all thank you!
Its great PR but its a huge one. It requires from me to check every page for ui.
I dont have so much time. I can take few first commits now and look at rest of it after 3.2 only.

@koenpunt
Copy link
Contributor Author

Ok, I can understand that. Should I split it in separate PR's?

@dzaporozhets
Copy link
Contributor

@koenpunt yes it will be great

@koenpunt koenpunt mentioned this pull request Nov 29, 2012
@koenpunt
Copy link
Contributor Author

koenpunt commented Dec 1, 2012

Closing this in favor of #2117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants