Autolinks to issues in commit message (see #155) #237

Merged
merged 4 commits into from Dec 27, 2011

2 participants

@CedricGatay

It matches #[0-9]+ in commit messages.
For example

  • Fix for #12
  • Code review for #56
  • Test for #15, Review on #54, Fix for #42

    It only links to valid issues (existing and belonging to the current project)
    It does not add any link to the commit in the issue page, it only consists in parsing the commit message when displayed.

    This can be considered as a primary work for the issue #155 on gitlabhq/gitlabhq.

CedricGatay added some commits Dec 26, 2011
@CedricGatay CedricGatay Autolinks to issues in commit message (see #155)
It matches #[0-9]+ in commit messages.
For example
 * Fix for #12
 * Code review for #56
 * Test for #15, Review on #54, Fix for #42

 It only links to valid issues (existing and belonging to the current project)
 It does not add any link to the commit in the issue page, it only consists in parsing the commit message when displayed.

 This can be considere as a primary work for the issue #155 on gitlabhq/gitlabhq.
443e21e
@CedricGatay CedricGatay Follow up of my pull request, damn last time refactor ! 5d9f2e7
@vsizov

1) do not have rspec
2) @commit.safe_message must be passed to helper.
3) preserve must be moved to your helper
4) space around operators.

@CedricGatay

I am a beginner in the ruby / ror world, I'll try to understand and do what you ask. Thanks for the feedback !

@vsizov

nice work as for beginner

CedricGatay added some commits Dec 26, 2011
@CedricGatay CedricGatay 1/ rspec'ed
2/ @commit.safe_message as an argument
3/ preserve in helper
4/ spaces around operators
89a03a3
@CedricGatay CedricGatay I have to domesticate RubyMine, keymapping is not the same as Intelli…
…J and I have deleted a character by mistake...
0aef2fe
@vsizov vsizov merged commit 5d6e79f into gitlabhq:master Dec 27, 2011
@randx randx added a commit that referenced this pull request Dec 4, 2015
@randx randx Merge branch 'ldap_group_integration' into 'master'
Ldap group integration

closes #237

See merge request !307
1bf4836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment