Gitlab/Gitolite: Support anonymous access through the git daemon #2558

Closed
wants to merge 4 commits into
from

Projects

None yet

2 participants

@Olipro
Olipro commented Jan 10, 2013

This adds the option for enabling and disabling anonymous access to a
repo via adding the pseudo-user "daemon" to gitolite's access list.

If anonymous Git access is enabled, GitLab will display the access link
on the repo.

Obviously, your GitD must be configured with the correct base directory
and execute as the appropriate user (probably git).

Oliver Gitlab/Gitolite: Support anonymous access through the git daemon
This adds the option for enabling and disabling anonymous access to a
repo via adding the pseudo-user "daemon" to gitolite's access list.

If anonymous Git access is enabled, GitLab will display the access link
on the repo.

Obviously, your GitD must be configured with the correct base directory
and execute as the appropriate user (probably git).
ab08871
@randx
Member
randx commented Jan 11, 2013

Thank you but I dont like an idea of git deamon.
Complicated implementation without benefits.
I will provide a solution over http in few days

@Olipro
Olipro commented Jan 11, 2013

I accept that it does come down to personal taste, but I don't think that's necessarily a valid justification for not offering it as an option... no doubt not everybody wants to pump Git traffic through their HTTPd either.

As it stands this is optional anyway, would it be satisfactory if it could be disabled entirely via a config variable?

Oliver added some commits Jan 11, 2013
Oliver Projects: Fix minor HAML markup error
An error in the haml markup was preventing from the Git Read-Only button
from rendering correctly.
e17462c
Oliver Projects: Fix incorrect GitD URL
The GitD url was based on the SSH url and thus incorrectly using a colon
as separator between the hostname and path. This corrects this by using
the HTTP hostname as the basis for path.
0425322
Oliver Projects: Simplify update_project_config
Previously, I had renamed the update_project_config function in
expectation of future manipulation, but given that Ruby supports using
one argument as the default for another, the current logic can be
disposed of and simplified.
0bacac4
@Toub Toub referenced this pull request Jan 14, 2013
Closed

Public Projects #12

@randx
Member
randx commented Jan 16, 2013

this one may help others. But i think it should be out of core. So I close this one

@randx randx closed this Jan 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment