Disable hard wrapping in GFM #2864

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@titanous

This is a follow-up to #2818 that disables the hard wrapping entirely with no config option.

@2called-chaos

I don't think this is gonna be merged. I think most people are happy with hard_wrap and also is it compliant to Github's parsing (well beside from HTML for some reason). Also this will break existing files and comments. Especially the latter is a part where I would expect hard wrapping.

Did you thought about maintaining a personal branch where you can cherry pick and manage your own personal changes (I removed the HTML restriction for example).

Github doesn't use hard wrap.

@mikkyhouse
Contributor

we keep current implementation for compatibility. thank you

@mikkyhouse mikkyhouse closed this Feb 25, 2013
@cdbennett

@titanous Perfect, this is awesome. Creating paragraph breaks from newlines is totally wrong, especially for Git commit messages which should be hard wrapped at 72 columns, but you would want this reflowed by a rendered rich text view.

@joshuaspence

This change should be merged. Writing a paragraph on a single line is painful and forcing a paragraph break at newline is just wrong. GitHub does not treat newlines in this way.

@cdbennett

What if someone makes a pull request that adds a config option to make the GitLab-flavor the default but the user can opt-in to the standard markdown line break treatment by setting a config file option? Perhaps that will be acceptable since it won't break backward compatibility.

@nat-n
nat-n commented Mar 19, 2014

Having to either write crazy long lines of text (or worse turn on wrapping in a text editor), or have non-sensical paragraph structure in markdown files is ridiculous.

Having at least a "sane documentation option" would be quite useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment