Skip to content

Conversation

@raphendyr
Copy link
Contributor

We should check exit status instead of look sting n output.

Someone need to validate the tests as I wrote them without testing...

I tested manually the code, so it works.

This should be merged to 4-1-stable and 4-2-stable too, as I think this is security update.

If this patch is not used, users might get gitolite (or any other) system in blocked state.

@raphendyr
Copy link
Contributor Author

Hmm. Did I broke tests or is there a bug... Damn..

If somebody has a pointers, they are welcome.

ps. I really need to get that test machine running...

@axilleas
Copy link
Contributor

The travis tests are broken for some time now. I think I saw someone mentioning that it's postgresql's fault.

@raphendyr
Copy link
Contributor Author

OK. Now travis errors are not from ssh stuff, I think. So I think I got ssh tests fixed.

@dzaporozhets
Copy link
Contributor

thank you

dzaporozhets added a commit that referenced this pull request Feb 18, 2013
@dzaporozhets dzaporozhets merged commit ea28519 into gitlabhq:master Feb 18, 2013
@raphendyr raphendyr deleted the ssh_fingerprint_fix branch February 19, 2013 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants