-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fixes grack authentification under relative_url_root #3204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Coverage decreased (-22.95%) when pulling 8945c90aa4e38e87570d9dd58f7f02bd0c41ef9d on atuleu:issue-3153 into 366bc32 on gitlabhq:master. |
|
Coverage decreased (-0.12%) when pulling cb6febc46137db2faadda2c291b64f24f6a560ee on atuleu:issue-3153 into 2f6d289 on gitlabhq:master. |
refs #1228 refs #3153
|
Finally itd does go green on travis. All of my pushes were working on my gitlab-vagrant machine, I had to rebase several tuime against master to make it work .... Does anyone have any idea why ? |
|
I'm not entirely sure this is the right way to fix this; however, without this http/https cloning is completely broken with a relative root set currently. |
|
Related to fixing relative root support in general is also #3458 . |
|
I agree that it may not be the better way to fix this, I just hacked it really quickly as I really needed http cloning for the intern gitlab of my lab. |
|
Works pretty well to fix http(s) cloning on 5.1-2 thanks |
|
Those two commits from @atuleu should be merged, they are still needed in gitlab 5.2 Proposed fix #3458 from @jrmithdobbs did not work for me. Cheers |
|
@randx can you take a look? |
|
Also see http://feedback.gitlab.com/forums/176466-general/suggestions/4102121-relative-url-support that makes a request to properly support relative urls again. |
|
I'd say please upvote the request in the feedback link to draw more attention to this as this feature is more useful to the "little guy" |
|
@randx will this be merged? The HTTP Clone issue still persists with Gitlab 5.0 - 5.3 when Gitlab is run under a relative URL. I'm currently on version 5.3 and this pull request resolves the issue => I can now happily clone and push via http with Gitlab running under the /gitlab path Thanks @atuleu 👍 |
|
@dosire I have seen that today some changement in the policy of relative url has been made. Could you comment zyourself or ask another dev that knows better the matter the two following question I put first in this PR :
Thank you for your help |
|
@atuleu Sorry, I don't know if there is a test for http cloning. Running the same travis test twice doesn't seem like a workable solution to me. Please discuss in http://feedback.gitlab.com/forums/176466-general/suggestions/4102121-relative-url-support |
|
Hi, I posted (almost) the same message on the issue and the feedback forum. There is no test for that particular feature. However I just tried to run I setted on atuleu/gitlabhq relative-url-root branch a travis environement bests 2013/7/31 Sytse Sijbrandij notifications@github.com
|
|
Fix included in #4670 |



grack fails under non relative_url_root . I tried to fix by stripping relative root if its is set.
I tried to find spec / features for git smart http acces but did not found any.
refs #1228
refs #3153