Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPersonal snipepts support added #3351
Conversation
Andrew8xx8
added some commits
Mar 23, 2013
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Mar 24, 2013
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Mar 24, 2013
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Mar 25, 2013
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Mar 25, 2013
This comment has been minimized.
This comment has been minimized.
|
Looks impressing. |
NARKOZ
reviewed
Mar 25, 2013
| def update | ||
| @snippet.update_attributes(params[:project_snippet]) | ||
| if @snippet.valid? |
This comment has been minimized.
This comment has been minimized.
NARKOZ
reviewed
Mar 25, 2013
config/routes.rb
Outdated
| get "raw" | ||
| end | ||
| end | ||
| match "/s/:username" => "snippets#user_index", as: :user_snippets, constraints: { username: /.*/ } |
This comment has been minimized.
This comment has been minimized.
Andrew8xx8
added some commits
Mar 25, 2013
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Mar 25, 2013
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Mar 25, 2013
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Mar 25, 2013
This comment has been minimized.
This comment has been minimized.
|
+1 |
dzaporozhets
merged commit e0af7ce
into
gitlabhq:master
Jun 4, 2013
1 check failed
default
The Travis build failed
Details
This comment has been minimized.
This comment has been minimized.
|
@Andrew8xx8 yay! Finally got this merged. Thank you for good quality code |
dichen001
referenced this pull request
Jun 28, 2016
Open
Summary of the 20 issues in Herbsleb's 2014 FSE paper. #6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Andrew8xx8 commentedMar 24, 2013
My first step to implement a good feature:
Looks like this:
Plans: