Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal snipepts support added #3351

Merged
merged 28 commits into from Jun 4, 2013
Merged

Conversation

Andrew8xx8
Copy link
Contributor

My first step to implement a good feature:

  • Added new page for snippets managment
  • Added new type of snippets. Personal snippets
  • Added Public/Private snippets support (All projects snippets will be private)
  • Spinach tests for snippets (Whohooo!)

Looks like this:

Screenshot 2013-03-25 02 14 54
 2013-03-25 2 16 18
 2013-03-25 2 20 06

Plans:

  • Search
  • Add versions support

@coveralls
Copy link

Coverage decreased (-11.61%) when pulling ed4dcf7 on Andrew8xx8:gist into 5f159d4 on gitlabhq:master.

View Details

@coveralls
Copy link

Coverage decreased (-2.83%) when pulling 611ac72 on Andrew8xx8:gist into 5f159d4 on gitlabhq:master.

View Details

@coveralls
Copy link

Coverage decreased (-45.14%) when pulling d4543eb on Andrew8xx8:gist into 5f159d4 on gitlabhq:master.

View Details

@coveralls
Copy link

Coverage decreased (-11.96%) when pulling 033037a on Andrew8xx8:gist into 5f159d4 on gitlabhq:master.

View Details

@dzaporozhets
Copy link
Member

Looks impressing.
Since I'm a bit busy with some other stuff I'll made a review in a week or something.
Please be patient. And thank you for contribution :)

def update
@snippet.update_attributes(params[:project_snippet])

if @snippet.valid?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if @snippet.update_attributes(params[:project_snippet])

@coveralls
Copy link

Coverage increased (+0.22%) when pulling 3e695ac on Andrew8xx8:gist into 5f159d4 on gitlabhq:master.

View Details

@coveralls
Copy link

Coverage decreased (-11.68%) when pulling 03de5a5 on Andrew8xx8:gist into 5f159d4 on gitlabhq:master.

View Details

@coveralls
Copy link

Coverage increased (+0.07%) when pulling e0af7ce on Andrew8xx8:gist into 5f159d4 on gitlabhq:master.

View Details

@Razer6
Copy link
Member

Razer6 commented Apr 30, 2013

+1

@dzaporozhets dzaporozhets merged commit e0af7ce into gitlabhq:master Jun 4, 2013
@dzaporozhets
Copy link
Member

@Andrew8xx8 yay! Finally got this merged. Thank you for good quality code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants