-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fork v5 #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork v5 #3382
Conversation
Change-Id: I5f73592261bc64bae0c97bd0f10f37197a6714a4
Change-Id: I36bbfc77c8cf895489ba78dd66fdd9d2b62ca891
|
Neat idea. I hope it can make it in |
|
👍 |
|
Hi @amacarthur , Does fork repo is shared with parent repo ? or Has repos duplication issue taken care of ? |
|
As I mentioned in previous PR please dont do a fork with grit library. It should be handled by gitlab-shell |
|
It wasn't clear to me from previous PR that I was unable to use the Grit library. It seems that you are not using Grit in gitlab-shell at all. Is there a particular reason you are avoiding using Grit? To clarify what I need to change:
Is there anything else that needs addressing? |
|
@amacarthur Yeap we have Yes you need to:
|
|
Feel free to ask if something is unclear |
|
👍 Does the PR also include creating a merge request from a forked repo to the original? I'd didn't immediately find it in the changes, but then again I'm not really familiar with the GitLab codebase :) In any case, I might be able to find some free time if you need help, @amacarthur |
|
this patch does not enhance merge requests to support cross project merges. That is certainly something that I am interested in pursuing, but I don't have a firm timeframe for implementation yet. From an initial investigation, I believe the existing merge request structure should support cross-project merges without too much effort. Perhaps you'd like to start work on expanding merge requests? I am preparing a patch which address @randx points. This should be available very soon. |
|
I'll try to make some time to look at cross-repo merge requests then :) |
|
I have a question for you @randx. I am putting together a new pull request. I believe I have something worth submitting, but have encountered an issue I hope you can help me with. I wrote the updated version branched off the latest stable versions of gitlab-shell and gitlabhq. All my test run clean of v5 of gitlabhq, but I have encountered errors when I attempt to update to the latest master. When using factory_girl to create a project to fork from, the project no longer has a repository attached, which causes my fork tests to fail. I am unfamiliar with factory_girl and am having some trouble debugging it to locate my problem. I notice that there has been some refactoring around stubbed_repository and a recent addition of TestEnv, and I suspect my trouble may lie there. Originally I had a line of code that created a project like so: This would give me project with a repo which I could successfully fork from. Looking at the other examples to see how I should update my tests, I have tried using the following: but am still creating a project with no repo that I cannot fork from. Is there something I am missing? |
|
Disregard above comment. I have solved my problem. Updated pull request coming. |
|
Closed in favour of : #3597 |
|
When can we expect "git-alternate" feature in GitLab to avoid dedup of forked repos ? I have raised the feature request at http://feedback.gitlab.com/forums/176466-general/suggestions/4027712-save-disk-space-git-alternates-to-eleminate-re |
|
I have responded on the feedback forum thread you linked to. |
This is an updated version of the previously rejected pull request:
.