-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Authenticate LDAP users in the grack module - fixed problems - tested code #3758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/gitlab/backend/grack_auth.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not return false if user.nil?
|
@fredowski thanks for this one. I'll merge it if you correct few things |
|
@randx thanks for your remarks. I modified the code according to your comments. In the last commit 20a88f5 I
I hope I did not forget too much. This is my first ruby code... |
|
@fredowski thank you. Good that you tested it in several cases |
Authenticate LDAP users in the grack module - fixed problems - tested code
Fix #3758: Serious performance issues due to timeago() being called n*(n+1)/2 times instead of n See bug #3758 for a description. This merge request alters `time_ago_with_tooltip` to invoke the `timeago()` javascript on the current timestamp only, instead of each one defined on the page so far. See merge request !1977
This is based on the Pull Request #3141 from @jasl8r and Pull Request #3470 from @drahamim. I added the ideas from @randx
So this will add LDAP Authentification in the grack module. With this I can push via https for users which have LDAP or Email authentification. Discussion about this topic was in #2012 and #2557.