Fix 3171 #3851

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants

slide commented May 6, 2013

Added option with the same value as development.rb with documentation on how to edit it to get the correct URL's in emails.

Fix 3171
Added option with the same value as development.rb with documentation on how to edit it to get the correct URL's in emails.

Coverage Status

Coverage decreased (-0.09%) when pulling 2eb334c on slide:master into 3022b9f on gitlabhq:master.

Contributor

senny commented May 7, 2013

can you change the commit message to: "include example mailer options. Fixes #3171"

@slide slide closed this May 7, 2013

Contributor

senny commented May 7, 2013

Why did you close this PR? You can always force push on your branch and GitHub will automatically update the PR. No need to reopen the same patch and loose the discussion.

slide commented May 7, 2013

Ah, I'm still fairly new to github, sorry.

On Tue, May 7, 2013 at 4:28 AM, Yves Senn notifications@github.com wrote:

Why did you close this PR? You can always force push on your branch and
GitHub will automatically update the PR. No need to reopen the same patch
and loose the discussion.


Reply to this email directly or view it on GitHubhttps://github.com/gitlabhq/gitlabhq/pull/3851#issuecomment-17536721
.

Website: http://earl-of-code.com

Contributor

senny commented May 7, 2013

no problem, you can use it next time.

stanhu pushed a commit that referenced this pull request Feb 12, 2016

Merge branch 'streamline-email-validation' into 'master'
Validate email addresses using Devise.email_regexp

Also:
- Get rid of legacy `:strict_mode`
- Get rid of custom `:email` validator
- Add some shared examples to spec emails validation

This supersedes !2754 and fixes #3851.

See merge request !2771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment